From: Daniel Colascione <dancol@dancol.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Inlining doesn't happen on OS X: big performance problem
Date: Thu, 19 Sep 2013 13:58:22 -0700 [thread overview]
Message-ID: <523B656E.7020700@dancol.org> (raw)
In-Reply-To: <87y56s3h2f.fsf@igel.home>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On 9/19/13 9:35 AM, Andreas Schwab wrote:
> Daniel Colascione <dancol@dancol.org> writes:
>
>> Can we please remove these "!defined __APPLE__" tests and start inlining
>> functions again in OS X?
>
> Why doesn't the compiler inline static functions by itself?
Why should it?
Also, I don't see why we've been going through the tree and replacing
instances of "static inline" with "static": sure, it's possible for the
compiler to inline non-"inline" functions, and even functions marked
"inline" might not get inlined, but "static inline" is a good hint and
makes inlining much more likely. Why should we remove this hint?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2013-09-19 20:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 13:35 Inlining doesn't happen on OS X: big performance problem Daniel Colascione
2013-09-19 13:44 ` Ryan Johnson
2013-09-19 15:06 ` Paul Eggert
2013-09-19 21:41 ` Paul Eggert
2013-09-20 1:47 ` Daniel Colascione
2013-09-20 4:24 ` Paul Eggert
2013-09-19 16:35 ` Andreas Schwab
2013-09-19 20:58 ` Daniel Colascione [this message]
2013-09-19 21:04 ` Andreas Schwab
2013-09-19 21:11 ` Daniel Colascione
2013-09-19 21:15 ` Andreas Schwab
2013-09-19 21:19 ` Óscar Fuentes
2013-09-19 21:18 ` Paul Eggert
2013-09-19 22:35 ` Ryan Johnson
2013-09-19 22:57 ` Paul Eggert
2013-09-20 2:35 ` Ryan Johnson
2013-09-20 6:14 ` Jan Djärv
2013-09-20 8:15 ` Dmitry Antipov
2013-09-20 14:17 ` Stefan Monnier
2013-09-20 15:37 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B656E.7020700@dancol.org \
--to=dancol@dancol.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).