From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: tags Date: Sun, 16 Jun 2019 03:30:43 +0300 Message-ID: <52332265-2d02-a01c-e221-20b00b1edf86@yandex.ru> References: <831rzvvsgp.fsf@gnu.org> <83y322vqvg.fsf@gnu.org> <83v9x6vpap.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="116750"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 To: Lars Ingebrigtsen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 16 02:32:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcJ6L-000UDE-Is for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 02:32:53 +0200 Original-Received: from localhost ([::1]:37076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcJ6K-0001eY-M1 for ged-emacs-devel@m.gmane.org; Sat, 15 Jun 2019 20:32:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47006) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcJ4q-0001ZI-WD for emacs-devel@gnu.org; Sat, 15 Jun 2019 20:31:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcJ4p-0002kR-RG for emacs-devel@gnu.org; Sat, 15 Jun 2019 20:31:20 -0400 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:54295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcJ4n-0002V9-8e for emacs-devel@gnu.org; Sat, 15 Jun 2019 20:31:17 -0400 Original-Received: by mail-wm1-x335.google.com with SMTP id g135so5768817wme.4 for ; Sat, 15 Jun 2019 17:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZSMK+GIzq58ImDmUuIow7Vpi+0C2xwoAuvZvc4GdbVE=; b=lwL6A7cqxwPTxE+kRI0OoB+pur2TQk+w14i7iUPfYLlZoBDQ0k/Hy4snYaxQXTgJwF FzH1fECzlZx20x+8BfRp4dNGPZ51+vmc9zX2PjBElm/52mNDuNLerchzCo7VWTQpWQDH wT64GzfCZJqFMqWrh7/AAL9+CVacvxBH3DbPChKZJFJNMK8vtpsSS7G0+5NTOMl7TH/d xcvoHkqBCr/uOzLotSkSudMGOpV8tWshQaDpFAjuST4hz+2TV1dVsvyzIF00eVA+xfUc PUE7IBeBmyy8QgvWvbRm7XofUqqd6ot5kLzI1izXnjIz93irdiLbd95e2/SxQrwlzXbK ft5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZSMK+GIzq58ImDmUuIow7Vpi+0C2xwoAuvZvc4GdbVE=; b=SKqkSoBeMUwymfpujzwsNt7+9fjxt53q9jPJmt9opyHz1Kb+XXyqAvMUVwNxjoStUf fyRWzVVlQ8E33YLLj7DagVdvc/+oZ1FkN/AmcxWN1fnDqHuh+gbjdcx2LmD32JR/AF4x tZ91IWmv1AUMg7bfYFy+DspMidtWNbVEhVd3fQUgZS9xdNBue3dWTmptIVO8Ol7jKLxw KUEah25HjT6lMPhLrYJJj99598eerEQ+DtJ9GvXj1gNzzrnJIAKKs9/b0PmBralBFD/O 4hc+TkTkXvRzgRXyFMbH5bKWLWRN77iCtONuos1WttjNVrkrGDGp0QcJLYvkj3nlLTYR 7zBA== X-Gm-Message-State: APjAAAXDcaZHkHlb9ttwAB8LUsm52q9jsYC/Gfk/ZzQINBluLBw7bmF2 OXACqRpUWxovqrzFL9skd8458dS4Ptw= X-Google-Smtp-Source: APXvYqxT5RhwEI7J+aQDsQkQk3piCBwvkW4sLBKFYSM0L8nrg+SBx+UW+TU9/kDJwuoP+4FYSMhZlA== X-Received: by 2002:a1c:9d86:: with SMTP id g128mr14091135wme.51.1560645046338; Sat, 15 Jun 2019 17:30:46 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id z5sm5432409wmf.48.2019.06.15.17.30.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jun 2019 17:30:45 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::335 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237708 Archived-At: On 15.06.2019 19:11, Lars Ingebrigtsen wrote: > 27% of the remaining Warning: lines are related to the introduction of > the new xref code, I think: > > emulation/viper-ex.el:2019:16:Warning: `find-tag' is an obsolete function (as > of 25.1); use `xref-find-definitions' instead. > emulation/viper-ex.el:2020:14:Warning: `find-tag-other-window' is an obsolete > function (as of 25.1); use `xref-find-definitions-other-window' instead. > eshell/esh-mode.el:499:6:Warning: `find-tag' is an obsolete function (as of > 25.1); use `xref-find-definitions' instead. > textmodes/reftex-global.el:101:6:Warning: tags-query-replace called with 4 > arguments, but accepts only 2-3 > vc/vc-dir.el:826:4:Warning: tags-query-replace called with 4 arguments, but > accepts only 2-3 > > These functions are obsolete (or are called with the wrong number of > arguments), but as far as I can tell, there are no direct substitutions > for these functions (or arguments). > > As Emacs 25.1 was a while ago, it would be really nice if somebody were > to write the glue code what would allow us to get rid of these > warnings. :-) FWIW, I believe tags-query-replace has an adequate replacement already in the fileloop package (as you can see it's already implemented in terms of it). That would take care of the last two warnings. esh-mode.el has a peculiar use for find-tag in creating a special version of it that "ignores whether the text is read-only". I'm not sure why that would matter since the command does not modify the buffer contents. Should we just remove the command and the custom binding? Not sure if eshell-mode just set up xref-find-functions as well. Is it supposed to use a tags table, or find-func.el? As for viper, I guess the emulation stuff has some UI requrements? Otherwise we could use xref-find-definitions and xref-find-definitions-other-window there.