Re: trunk r113953: * image.c: Shrink memory needed for animation cache.

Re: trunk r113953: * image.c: Shrink memory needed for animation cache.

[Lars Magne Ingebrigtsen]

Paul Eggert <eggert@cs.ucla.edu> writes:

> +/* Size of ImageMagick image signatures, in bytes.  It's SHA-256 as a
> +   hex string, so it's 256 bits represented via 4 bits per byte.  */
> +enum { SIGNATURE_DIGESTSIZE = 256 / 4 };

Do we really need to know this?  It's a zero-terminated string (in a
larger block), so just by calling strdup, we're OK, and we don't need
any magical constants.

-- 
(domestic pets only, the antidote for overdose, milk.)
  No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
  and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html

Re: trunk r113953: * image.c: Shrink memory needed for animation cache.

[Paul Eggert]

Lars Magne Ingebrigtsen wrote:
> Do we really need to know this?  It's a zero-terminated string (in a
> larger block), so just by calling strdup, we're OK, and we don't need
> any magical constants.

Calling strdup would mean we'd be calling malloc twice
instead of once.  Insted, we can make the signature a flexible
array member.  This is a bit slower than what we had, but it's
better than calling malloc twice and it would insulate us better
if ImageMagick switches to a different digest format.
I did that in trunk bzr 113954.