From: Paul Eggert <eggert@cs.ucla.edu>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r113953: * image.c: Shrink memory needed for animation cache.
Date: Mon, 19 Aug 2013 17:53:55 -0700 [thread overview]
Message-ID: <5212BE23.9000604@cs.ucla.edu> (raw)
In-Reply-To: <m34nalmfq0.fsf@stories.gnus.org>
Lars Magne Ingebrigtsen wrote:
> Do we really need to know this? It's a zero-terminated string (in a
> larger block), so just by calling strdup, we're OK, and we don't need
> any magical constants.
Calling strdup would mean we'd be calling malloc twice
instead of once. Insted, we can make the signature a flexible
array member. This is a bit slower than what we had, but it's
better than calling malloc twice and it would insulate us better
if ImageMagick switches to a different digest format.
I did that in trunk bzr 113954.
prev parent reply other threads:[~2013-08-20 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VBWMN-0000q0-1s@vcs.savannah.gnu.org>
2013-08-19 23:19 ` trunk r113953: * image.c: Shrink memory needed for animation cache Lars Magne Ingebrigtsen
2013-08-20 0:53 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5212BE23.9000604@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).