From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: trunk r113947: * image.c: Fix animation cache signature memory leak. Date: Mon, 19 Aug 2013 09:16:48 -0700 Organization: UCLA Computer Science Department Message-ID: <521244F0.3060508@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1376929032 11988 80.91.229.3 (19 Aug 2013 16:17:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Aug 2013 16:17:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 19 18:17:14 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VBS8o-0003LY-04 for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 18:17:14 +0200 Original-Received: from localhost ([::1]:44011 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBS8n-0002PH-7f for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 12:17:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBS8d-0002EZ-41 for emacs-devel@gnu.org; Mon, 19 Aug 2013 12:17:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBS8V-0004E4-OT for emacs-devel@gnu.org; Mon, 19 Aug 2013 12:17:03 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:34189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBS8V-0004Da-Ig for emacs-devel@gnu.org; Mon, 19 Aug 2013 12:16:55 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 4B04DA60005; Mon, 19 Aug 2013 09:16:54 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kYXjISN8hTeu; Mon, 19 Aug 2013 09:16:53 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-71-108-49-126.lsanca.fios.verizon.net [71.108.49.126]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id C5EB9A60004; Mon, 19 Aug 2013 09:16:53 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 In-Reply-To: X-Enigmail-Version: 1.5.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162880 Archived-At: Lars Magne Ingebrigtsen wrote: > Seriously? That's a performance problem? I did say it was minor. :-) I think it's clearer if the code initializes things just once, but if you think it clearer the other way please feel free to revert it. > you didn't test it, > because it segfaulted the first time it was called. I did test it, but evidently not with enough test cases. Sorry about the bug. To avoid such problems in the future, should we funnel future image.c changes through you? Here's a tiny style issue that should be fixed at some point: the version you inserted has "strcmp(" in a couple of places where it should be "strcmp (".