* Re: [Emacs-diffs] trunk r113888: * image.c (imagemagick_compute_animated_image): Implement animated images.
@ 2013-08-15 15:48 Dmitry Antipov
2013-08-15 16:33 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Antipov @ 2013-08-15 15:48 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: Emacs development discussions
/home/dima/work/stuff/emacs/trunk/src/image.c: In function ‘imagemagick_compute_animated_image’:
/home/dima/work/stuff/emacs/trunk/src/image.c:7913:5: error: pointer targets in passing argument 2 of ‘PixelGetNextIteratorRow’ differ in signedness [-Werror=pointer-sign]
while (source = PixelGetNextIteratorRow (source_iterator, &source_width)) {
^
In file included from /usr/include/ImageMagick/wand/deprecate.h:29:0,
from /usr/include/ImageMagick/wand/MagickWand.h:68,
from /home/dima/work/stuff/emacs/trunk/src/image.c:7817:
/usr/include/ImageMagick/wand/pixel-iterator.h:52:5: note: expected ‘size_t *’ but argument is of type ‘long int *’
**PixelGetNextIteratorRow(PixelIterator *,size_t *),
^
/home/dima/work/stuff/emacs/trunk/src/image.c:7913:5: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
while (source = PixelGetNextIteratorRow (source_iterator, &source_width)) {
^
/home/dima/work/stuff/emacs/trunk/src/image.c:7914:7: error: pointer targets in passing argument 2 of ‘PixelGetNextIteratorRow’ differ in signedness [-Werror=pointer-sign]
dest = PixelGetNextIteratorRow (dest_iterator, &dest_width);
^
In file included from /usr/include/ImageMagick/wand/deprecate.h:29:0,
from /usr/include/ImageMagick/wand/MagickWand.h:68,
from /home/dima/work/stuff/emacs/trunk/src/image.c:7817:
/usr/include/ImageMagick/wand/pixel-iterator.h:52:5: note: expected ‘size_t *’ but argument is of type ‘long int *’
**PixelGetNextIteratorRow(PixelIterator *,size_t *),
^
cc1: all warnings being treated as errors
Could you please use an up-to-date compiler and --enable-gcc-warnings
--enable-check-lisp-object-type --enable-checking for development?
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] trunk r113888: * image.c (imagemagick_compute_animated_image): Implement animated images.
2013-08-15 15:48 [Emacs-diffs] trunk r113888: * image.c (imagemagick_compute_animated_image): Implement animated images Dmitry Antipov
@ 2013-08-15 16:33 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2013-08-15 16:33 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: larsi, emacs-devel
> Date: Thu, 15 Aug 2013 19:48:27 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Cc: Emacs development discussions <emacs-devel@gnu.org>
>
> /home/dima/work/stuff/emacs/trunk/src/image.c: In function ‘imagemagick_compute_animated_image’:
> /home/dima/work/stuff/emacs/trunk/src/image.c:7913:5: error: pointer targets in passing argument 2 of ‘PixelGetNextIteratorRow’ differ in signedness [-Werror=pointer-sign]
> while (source = PixelGetNextIteratorRow (source_iterator, &source_width)) {
> ^
> In file included from /usr/include/ImageMagick/wand/deprecate.h:29:0,
> from /usr/include/ImageMagick/wand/MagickWand.h:68,
> from /home/dima/work/stuff/emacs/trunk/src/image.c:7817:
> /usr/include/ImageMagick/wand/pixel-iterator.h:52:5: note: expected ‘size_t *’ but argument is of type ‘long int *’
> **PixelGetNextIteratorRow(PixelIterator *,size_t *),
> ^
> /home/dima/work/stuff/emacs/trunk/src/image.c:7913:5: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
> while (source = PixelGetNextIteratorRow (source_iterator, &source_width)) {
> ^
> /home/dima/work/stuff/emacs/trunk/src/image.c:7914:7: error: pointer targets in passing argument 2 of ‘PixelGetNextIteratorRow’ differ in signedness [-Werror=pointer-sign]
> dest = PixelGetNextIteratorRow (dest_iterator, &dest_width);
> ^
> In file included from /usr/include/ImageMagick/wand/deprecate.h:29:0,
> from /usr/include/ImageMagick/wand/MagickWand.h:68,
> from /home/dima/work/stuff/emacs/trunk/src/image.c:7817:
> /usr/include/ImageMagick/wand/pixel-iterator.h:52:5: note: expected ‘size_t *’ but argument is of type ‘long int *’
> **PixelGetNextIteratorRow(PixelIterator *,size_t *),
> ^
> cc1: all warnings being treated as errors
>
> Could you please use an up-to-date compiler and --enable-gcc-warnings
> --enable-check-lisp-object-type --enable-checking for development?
These are BS warnings, IMO. You will be better off disabling them
altogether.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-15 16:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-15 15:48 [Emacs-diffs] trunk r113888: * image.c (imagemagick_compute_animated_image): Implement animated images Dmitry Antipov
2013-08-15 16:33 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).