From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Small improvements to ruby-mode Date: Tue, 09 Jul 2013 21:18:10 +0400 Message-ID: <51DC45D2.4090200@yandex.ru> References: <2A6700DEDCA640EF92B326002717596D@gmail.com> <51D1CB5A.2060900@yandex.ru> <51D1F98D.3060900@yandex.ru> <51D31E12.7060002@yandex.ru> <51D4476A.40107@yandex.ru> <51D6A02C.2020207@yandex.ru> <51D6D500.7080306@yandex.ru> <51DB6516.1090708@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1373390306 21964 80.91.229.3 (9 Jul 2013 17:18:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Jul 2013 17:18:26 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 09 19:18:27 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UwbYZ-0005XK-5n for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2013 19:18:27 +0200 Original-Received: from localhost ([::1]:41676 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwbYY-0001zO-KC for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2013 13:18:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwbYS-0001vt-Mi for emacs-devel@gnu.org; Tue, 09 Jul 2013 13:18:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwbYJ-0001DZ-RO for emacs-devel@gnu.org; Tue, 09 Jul 2013 13:18:20 -0400 Original-Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:57551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwbYJ-0001Cq-Jm for emacs-devel@gnu.org; Tue, 09 Jul 2013 13:18:11 -0400 Original-Received: by mail-la0-f52.google.com with SMTP id fo12so4987672lab.39 for ; Tue, 09 Jul 2013 10:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-antivirus:x-antivirus-status; bh=tZE/SFlJ0oN/dEyTBKgDTOjze/YmfYvjLmDTBJhNjmU=; b=iLBeXTLeD8J/9LVkTrYnKjP4Qm2PSOR2BZrwTsHkPeBMBJsXEtd4clN6dmcqGEB3Zb epmUVDDdqwnx1rqTsrGPWmMlfhQSb3CsoMM1Cd2tFCZVQPNiT/9ahCBR9zsHHyI5555g ZxqUhaCYt5uTTDbhSBOB5BgiPZ3YEsauQZKCWXQGAQ6uBa/JpE2CQnyisvCSzPZVSmEi IInALJYbtraW1ApTGt2A1qfs/D9p+StwtITM3zmOF8KSWiQn4OhMstxyv62/P1CPHpZW 2dgwaGIOCOIiKGrnDGdj2ghwqXKFmic98hKTTeVoMGNvDH6nJroJddDDX3gWfwyre9P6 7vNQ== X-Received: by 10.112.125.199 with SMTP id ms7mr13258674lbb.29.1373390290655; Tue, 09 Jul 2013 10:18:10 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id k10sm9368584lbl.10.2013.07.09.10.18.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Jul 2013 10:18:09 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 In-Reply-To: X-Antivirus: avast! (VPS 130709-1, 09.07.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161777 Archived-At: On 09.07.2013 20:07, Bozhidar Batsov wrote: > Currently we use the same face (font-lock-type-face) for both > classes/modules and constants. Classes and Modules are mandatory > CamelCase(although Camel_Case is also valid, albeit it's considered > extremely poor style) and just about everyone uses SCREAMING_SNAKE_CASE > for constants so I'd suggest to use font-lock-constant-face for constants. Oh, but we already use font-lock-constant-face. For symbols. :) Considering that, in Ruby, class names are also constants, highlighting both with the same face doesn't look too bad. I guess we can swap the two faces, but I'm kind of used to the way ruby-mode buffers look now. IOW, users may find it disruptive.