From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Small improvements to ruby-mode Date: Fri, 05 Jul 2013 14:30:04 +0400 Message-ID: <51D6A02C.2020207@yandex.ru> References: <2A6700DEDCA640EF92B326002717596D@gmail.com> <87txkrm46t.fsf@yandex.ru> <6EF2AEF8D67840A2AF1C908AA3D0725F@gmail.com> <51C5A67A.2020002@yandex.ru> <51C6EA5F.2040408@yandex.ru> <51D1CB5A.2060900@yandex.ru> <51D1F98D.3060900@yandex.ru> <51D31E12.7060002@yandex.ru> <51D4476A.40107@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1373020515 27207 80.91.229.3 (5 Jul 2013 10:35:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Jul 2013 10:35:15 +0000 (UTC) Cc: emacs-devel To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 05 12:35:17 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uv3M4-0005M3-Fm for ged-emacs-devel@m.gmane.org; Fri, 05 Jul 2013 12:35:08 +0200 Original-Received: from localhost ([::1]:36315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uv3M3-0004HG-Nl for ged-emacs-devel@m.gmane.org; Fri, 05 Jul 2013 06:35:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uv3Lx-0004E2-7a for emacs-devel@gnu.org; Fri, 05 Jul 2013 06:35:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uv3HD-0006vI-5b for emacs-devel@gnu.org; Fri, 05 Jul 2013 06:30:20 -0400 Original-Received: from mail-la0-x22f.google.com ([2a00:1450:4010:c03::22f]:58291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uv3HC-0006tg-Rk for emacs-devel@gnu.org; Fri, 05 Jul 2013 06:30:06 -0400 Original-Received: by mail-la0-f47.google.com with SMTP id fe20so1948196lab.34 for ; Fri, 05 Jul 2013 03:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-antivirus:x-antivirus-status; bh=kmrsgpx9u9il9QoHpaSGbeMs3JSPT+Cviq3jvsGQoK4=; b=Qw73OrEIZpnpJLTatdnuupV+pv6WREtjt5wojCy3QCidYLGo8gQtLVgH4iaSlFbQgC Uhr/Dlux9umy3Ejxax0rriC+1OQLVG+q1SwoQGaGmOwiqdFoKu6sz+vKlSm23Dm2nYvM /0n4Ed504YgsghzFsppv8TVFnmyo28GcWkccUnVeb1tElsNhHV+IRkdV0zmgoNLJum3O TWhV/LGqaREafquFmx+cdee5Pcp7d4sAtklJazD1TkRM4HfKLIOUPHAd/JsUrMEV68gw rL27GYQSTnx9JdfMYJjYr+iEvj4osR39ZfO6istzbwlT2rvYj18uW8TgTkYpGHZVTziu 9Z+A== X-Received: by 10.112.35.167 with SMTP id i7mr5434004lbj.34.1373020205677; Fri, 05 Jul 2013 03:30:05 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id g7sm2626366lae.6.2013.07.05.03.30.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Jul 2013 03:30:04 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 In-Reply-To: X-Antivirus: avast! (VPS 130705-0, 05.07.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161573 Archived-At: On 05.07.2013 13:56, Bozhidar Batsov wrote: > The patch looks good with one minor problem - you've included `autoload` > twice (the second time it's in Module's methods). Thanks for the catch. > While on the subject of small improvements here's a few more ideas: > > * replace cl with cl-lib (that should be done eventually I guess) Yeah, I guess. > * update the front-matter comment since it's pretty out-of-date What exactly do you propose to change? If the file is installed manually, and if it's not autoloaded, the user has to add some auto-mode-alist entries. > * run a whitespace cleanup on the code :-) Untabify, you mean? It's the core's policy not to touch tabs vs. spaces until you meaningfully modify nearby code. > * highlight yard and rdoc special syntax in comments - like Emacs Lisp does Have you looked at https://github.com/pd/yard-mode.el/ ? The only problem with it I can see is, it sets eldoc-documentation-function, so it can't be used outside of comments. I guess we'll eventually need eldoc-documentation-functions hook, like we have for completions. > * make use of `font-lock-negation-char-face` for ! Uh, okay. Is it different from the default face, in any themes? > * maybe make of use of new `font-log-regexp-grouping-construct-face` as well I think highlighting backslash sequences is more important, and the two approaches are somewhat incompatible. See: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14481 https://github.com/dgutov/highlight-escape-sequences P.S. Please try to keep emacs-devel in Cc.