From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jean-Christophe Helary Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Sat, 6 May 2017 11:41:14 +0900 Message-ID: <51D5E92C-F125-4ADE-8C55-E3513C00ECDC@gmail.com> References: <87vapij1l7.fsf@holos> <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1494038530 28738 195.159.176.226 (6 May 2017 02:42:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 May 2017 02:42:10 +0000 (UTC) Cc: emacs-devel To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 06 04:42:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6pfZ-0007OI-Eg for ged-emacs-devel@m.gmane.org; Sat, 06 May 2017 04:42:05 +0200 Original-Received: from localhost ([::1]:49759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6pff-0002bn-4Z for ged-emacs-devel@m.gmane.org; Fri, 05 May 2017 22:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6pen-0002RQ-0W for emacs-devel@gnu.org; Fri, 05 May 2017 22:41:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6pej-0003pe-SW for emacs-devel@gnu.org; Fri, 05 May 2017 22:41:17 -0400 Original-Received: from mail-pf0-x232.google.com ([2607:f8b0:400e:c00::232]:33557) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d6pej-0003p8-NH for emacs-devel@gnu.org; Fri, 05 May 2017 22:41:13 -0400 Original-Received: by mail-pf0-x232.google.com with SMTP id q20so10192577pfg.0 for ; Fri, 05 May 2017 19:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=OOoJwbwEKs3pF+CCu9FTLDokzXo6KjVAvMAuw6Ldncw=; b=e03/DrPVtRq+gxCPuj33u0WVNi4TYVdhvWkvkwYFF/cYih980rU9eOUbpvPpTk9uqU m/tS8v0+0MTmW2xI9ngjNpuywwM6lsKPJl9iAS8JG8s5vQenwU3CGopcLXDOs/qG43d4 PUz/q8ImAxwNGvqEhYHRAG4aqcgcphRwCQec3eIpibjxv53cn7qIvGp61GzoG/zsKU6q EgLBuMb2hoEd+rR+A4Gtamt6LQvAJNHVJMjyczhRsLcAxWONKmcEdSaQKZIDcjE+Yv6L WtmFZ8C2SE8aZUm6Vdz1uIlUX+VXjDFn16OCoCNLxIE2Hwcoa/YrNvhdPHWs8b88VuLr OBpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=OOoJwbwEKs3pF+CCu9FTLDokzXo6KjVAvMAuw6Ldncw=; b=n+FBLY/bRor4lQCHttdTCrYUjq9V2zoS3pg3n6Mr2AGmWhkH61Cx5osmyuc2ViWt4H mO1bDePVJSrfJ0OBxnTo6ZeMc8yshPUnYWGkp0KSg5NKNAZXUcsQxSy+A7xdxgGSrK7q bgGdgihCp+9fzY78KnjECPGlbiwhzaOkrZLbJSLHOTgU4kLk5tfXZ+iidaKB6076CWUb ozBVUGMAhBSDa1PsvCrBhu4uJb8wjKR7gHQMhGrW3C/kynKiPYhBljfNNHqS16dJv9iH D/6gHhO1PW/OcmvvM7X6ScM0UJZbTKN/XKaiUoDDc6ji8ZRFrfReSE2wtBD/BNM/fsaE G40w== X-Gm-Message-State: AN3rC/43fvA9JqL6f1zE2QEjoIikQ24jx5S3mHCGVsSswL6rt/C+vvKA ljhg4df5rgoT+Bxf4uA= X-Received: by 10.99.173.71 with SMTP id y7mr6708567pgo.3.1494038472820; Fri, 05 May 2017 19:41:12 -0700 (PDT) Original-Received: from [10.182.208.135] (dcm1-221-170-66-71.tky.mesh.ad.jp. [221.170.66.71]) by smtp.gmail.com with ESMTPSA id r131sm8265336pgr.67.2017.05.05.19.41.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2017 19:41:11 -0700 (PDT) In-Reply-To: <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214597 Archived-At: Mark, do you have any suggestions regarding your remark? Jean-Christophe=20 > On May 3, 2017, at 10:13, Jean-Christophe Helary = wrote: >=20 >=20 >> On May 3, 2017, at 8:11, Mark Oteiza wrote: >=20 >> Basically everything in subr-x is either a macro or a defsubst, >>=20 >> As such, most uses of subr-x are done with (eval-when-compile = (require >> 'subr-x)). Won't the use of a global variable break these? >=20 > (defconst string-trim-default-regex "[ \t\n\r]+") > "The default value of the trimmed string for `string-trim'." >=20 > I have no idea what the effects would be. What would you suggest? >=20 > Jean-Christophe