From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar! Date: Wed, 26 Jun 2013 11:35:24 +0400 Message-ID: <51CA99BC.6040006@yandex.ru> References: <87y5cx0wh7.fsf@yandex.ru> <87ppy7e5ke.fsf@lifelogs.com> <87k3lnvr7c.fsf@yandex.ru> <51C8D889.5000404@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1372232141 8472 80.91.229.3 (26 Jun 2013 07:35:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Jun 2013 07:35:41 +0000 (UTC) Cc: Emacs development discussions To: Daniel Hackney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 26 09:35:42 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrkGS-0007lu-Qx for ged-emacs-devel@m.gmane.org; Wed, 26 Jun 2013 09:35:40 +0200 Original-Received: from localhost ([::1]:46508 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrkGS-00011W-CI for ged-emacs-devel@m.gmane.org; Wed, 26 Jun 2013 03:35:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrkGJ-00010r-Al for emacs-devel@gnu.org; Wed, 26 Jun 2013 03:35:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrkGF-0002vo-3x for emacs-devel@gnu.org; Wed, 26 Jun 2013 03:35:31 -0400 Original-Received: from mail-la0-x233.google.com ([2a00:1450:4010:c03::233]:61160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrkGE-0002vd-TT for emacs-devel@gnu.org; Wed, 26 Jun 2013 03:35:27 -0400 Original-Received: by mail-la0-f51.google.com with SMTP id fq12so13330520lab.10 for ; Wed, 26 Jun 2013 00:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-antivirus:x-antivirus-status; bh=0TQRzE45Z5ifAcjfdnkzkl1HxlPPohC3e/a3/Ed2wJ8=; b=EvkRP/46YuWKSYdv/HubkRBV8JESCxX4hpBoDghgn0vVoE5BMe4DqYgSXWoSDehI+F RxzYWk3soTqHOw7YtGVQYwxXNKeV7gqjI6JS0ysWINYMj/iPlTkbKtAlSFlfFAEtaYA/ i6DWvl35TAN51Fd1oWx7CDbnH9jYyWkcEOxruXM4tslJWLHmHOHaD6y3/VyXXRC7vly0 J4f7QHwCelrKD6i/bIMoiFZAw9L5ork7VUfvBldhk3u912m+9KSnoQRmA/nKDXJlGtks Qulp9ods37BJrnUD3psdxVhp8hZDRgUIMnX9V6EsciosZBWPHy3JghknuO1mHH65OOIG 8Lmw== X-Received: by 10.152.27.9 with SMTP id p9mr1308405lag.4.1372232125748; Wed, 26 Jun 2013 00:35:25 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id i9sm10239411lai.4.2013.06.26.00.35.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 26 Jun 2013 00:35:24 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 In-Reply-To: X-Antivirus: avast! (VPS 130625-1, 26.06.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161075 Archived-At: On 26.06.2013 1:49, Daniel Hackney wrote: > Dmitry Gutov wrote: >> I still have 6/10 failures, so far. > > That's odd. Make sure you remove "finder-inf.el{,c}" and re-make. Its > format has changed and it needs to be re-generated. I, of course, mean that the problems arise when trying to run your tests with the code that is currently in Emacs trunk. Stefan ported the main features, but the API is not identical. Currently at 5/10. > Good point. The raw vectors should be replaced with calls to > `package-desc-create' with the appropriate arguments. Already done. :) Locally. > That is probably > not necessary for testing, so the multi-file package directory could > be replaced with a single .tar. This means that all of the > package-building functions (and parts of `with-package-test') could be > removed as well. Good idea.