From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar! Date: Tue, 25 Jun 2013 03:38:49 +0400 Message-ID: <51C8D889.5000404@yandex.ru> References: <87y5cx0wh7.fsf@yandex.ru> <87ppy7e5ke.fsf@lifelogs.com> <87k3lnvr7c.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1372117143 9253 80.91.229.3 (24 Jun 2013 23:39:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Jun 2013 23:39:03 +0000 (UTC) Cc: Daniel Hackney , Emacs development discussions To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 25 01:39:03 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrGLf-0005M6-ES for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2013 01:39:03 +0200 Original-Received: from localhost ([::1]:45793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrGLe-0004yY-V8 for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2013 19:39:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrGLY-0004yG-IH for emacs-devel@gnu.org; Mon, 24 Jun 2013 19:39:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrGLT-0007Dc-CU for emacs-devel@gnu.org; Mon, 24 Jun 2013 19:38:56 -0400 Original-Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:46408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrGLT-0007Cj-5E for emacs-devel@gnu.org; Mon, 24 Jun 2013 19:38:51 -0400 Original-Received: by mail-lb0-f176.google.com with SMTP id z5so668519lbh.35 for ; Mon, 24 Jun 2013 16:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-antivirus:x-antivirus-status; bh=wfUNqcc17bbrnilJIXPec/BK/glIs/ehrWlprsqUntI=; b=WnXGnzE9g26oSINqwusVFp8oRcm6OL/FYfsK2mVnduOgT28MyOVhf+ib2Y89PY+Lao iAfaMJ3WerXfo8H36fd5qv8pIgLEdjPN77xwqnqDOsC10plmjKz+Xe5iZxSQG7+2wGtU dQZHx41wjiUa2rxp0iHsSy06u28VwPzmgAtZmo8tZ1E0jkKCR8Nt+wys2l5sH9a/jSDr osY7+ePaXGs9/9Vb+18/ozSRcEyuXE2J+fA+LfAkbpY4X0GTrs8XRhTXC8txVzZF9ar9 cfYj9eQSKyheBbZ+Gir9QE/Laan2vhnk0JmorzpQfPtg2b1TjPh03wGnrAeaYfe1R4iS /1Yg== X-Received: by 10.112.52.97 with SMTP id s1mr13856129lbo.8.1372117130012; Mon, 24 Jun 2013 16:38:50 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id u1sm7596264lag.5.2013.06.24.16.38.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Jun 2013 16:38:49 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 In-Reply-To: X-Antivirus: avast! (VPS 130624-2, 24.06.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160993 Archived-At: On 21.06.2013 18:56, Stefan Monnier wrote: >> AFAICT, you've omitted the whole "automated testing" part of the >> changes, which was one of the main things I liked personally. > > I indeed focused on the package.el part itself, since that was the > problematic part (where there was no clear description of what the > patch was trying to do). > >> Any particular reason? > > No, oversight only. Feel free to add it. Just an update, I've tried to bring the tests over today, but they're quite dependent on the implementation. I still have 6/10 failures, so far. One thing I've noticed that you omitted is the inclusion of the "commentary" field in the package-desc struct. Not sure what the justification for its inclusion was, but I've had to remove the related assertions from the test file. Daniel: One thing I definitely didn't like is the usage of raw cl-struct vectors as reference values to compare against. These are implementation details of cl-defstruct, and we have no business setting them in stone in a test suite for code that just uses defstruct. Relying on an external program (ginstall-info) is also not nice, for the usual alternative-OS-related reasons.