From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv4 1/4] `kill-buffer' runs query functions before checking buffer modification. Date: Mon, 24 Jun 2013 19:05:11 +0200 Message-ID: <51C87C47.4090300@gmx.at> References: <1c8f2cfbb1b7a321184c6d840763f1c60bbfc95b.1372076606.git.mina86@mina86.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1372093536 20156 80.91.229.3 (24 Jun 2013 17:05:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Jun 2013 17:05:36 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Michal Nazarewicz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 19:05:36 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrACs-0003pg-3E for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2013 19:05:34 +0200 Original-Received: from localhost ([::1]:41421 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrACr-0006VV-I9 for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2013 13:05:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrACk-0006MB-TA for emacs-devel@gnu.org; Mon, 24 Jun 2013 13:05:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrACg-000722-JG for emacs-devel@gnu.org; Mon, 24 Jun 2013 13:05:26 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:61442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrACg-00071i-9V for emacs-devel@gnu.org; Mon, 24 Jun 2013 13:05:22 -0400 Original-Received: from mailout-de.gmx.net ([10.1.76.29]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0Md1TA-1Ua31e3ADC-00IGJ2 for ; Mon, 24 Jun 2013 19:05:20 +0200 Original-Received: (qmail invoked by alias); 24 Jun 2013 17:05:20 -0000 Original-Received: from 62-47-51-28.adsl.highway.telekom.at (EHLO [62.47.51.28]) [62.47.51.28] by mail.gmx.net (mp029) with SMTP; 24 Jun 2013 19:05:20 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18e/NFhb8weaHAkfkWNm9Avl4Wrl2vvp1yxpMNvA7 iCQ5EG/D8lJ56b In-Reply-To: <1c8f2cfbb1b7a321184c6d840763f1c60bbfc95b.1372076606.git.mina86@mina86.com> X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160953 Archived-At: > * buffer.c (FKill_buffer): Run `kill-buffer-query-functions' > before checking whether buffer is modified. This lets > `kill-buffer-query-functions' cancel killing of the buffer or save > its content before `kill-buffer' asks user the "Buffer %s > modified; kill anyway?" question. We probably should guard against the case that the query functions manage to kill the buffer prematurely. martin