* Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more. [not found] <E1UnKYz-00063L-5u@vcs.savannah.gnu.org> @ 2013-06-16 17:07 ` Dmitry Gutov 2013-06-16 23:19 ` Stefan Monnier 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Gutov @ 2013-06-16 17:07 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: > ------------------------------------------------------------ > revno: 112980 > revision-id: monnier@iro.umontreal.ca-20130614032018-uowzljhh6kbvcp4i > parent: monnier@iro.umontreal.ca-20130614023128-iedxmujzz2ss1bwe > committer: Stefan Monnier <monnier@iro.umontreal.ca> > branch nick: trunk > timestamp: Thu 2013-06-13 23:20:18 -0400 ... > +(defun package-load-descriptor (pkg-dir) > + "Load the description file in directory PKG-DIR." > + (let ((pkg-file (expand-file-name (package--description-file pkg-dir) > + pkg-dir))) > + (when (file-exists-p pkg-file) > + (with-temp-buffer > + (insert-file-contents pkg-file) > + (emacs-lisp-mode) Is using emacs-lisp-mode here necessary? It breaks my configuration, because I have `paredit-mode' in `emacs-lisp-mode-hook', and it's installed via ELPA, and so when this function is called for the first time (at least), Paredit is not yet in `load-path'. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more. 2013-06-16 17:07 ` trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more Dmitry Gutov @ 2013-06-16 23:19 ` Stefan Monnier 2013-06-17 6:26 ` Dmitry Gutov 0 siblings, 1 reply; 5+ messages in thread From: Stefan Monnier @ 2013-06-16 23:19 UTC (permalink / raw) To: Dmitry Gutov; +Cc: emacs-devel > Is using emacs-lisp-mode here necessary? No. Can you make it a bug-report, please (or install a patch which just makes it use the emacs-lisp-mode syntax-table, since that's all that matters)? Stefan ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more. 2013-06-16 23:19 ` Stefan Monnier @ 2013-06-17 6:26 ` Dmitry Gutov 2013-06-17 14:32 ` Stefan Monnier 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Gutov @ 2013-06-17 6:26 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel On 17.06.2013 3:19, Stefan Monnier wrote: >> Is using emacs-lisp-mode here necessary? > > No. Can you make it a bug-report, please (or install a patch which > just makes it use the emacs-lisp-mode syntax-table, since that's all > that matters)? Sure, installed. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more. 2013-06-17 6:26 ` Dmitry Gutov @ 2013-06-17 14:32 ` Stefan Monnier 2013-06-17 17:42 ` Dmitry Gutov 0 siblings, 1 reply; 5+ messages in thread From: Stefan Monnier @ 2013-06-17 14:32 UTC (permalink / raw) To: Dmitry Gutov; +Cc: emacs-devel >>> Is using emacs-lisp-mode here necessary? >> No. Can you make it a bug-report, please (or install a patch which >> just makes it use the emacs-lisp-mode syntax-table, since that's all >> that matters)? > Sure, installed. Actually, that was silly: since the code just uses `read' it doesn't even need the syntax table (all this is because of some earlier code I used which did need the syntax-table, and I didn't update my brain according to the new code). Stefan ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more. 2013-06-17 14:32 ` Stefan Monnier @ 2013-06-17 17:42 ` Dmitry Gutov 0 siblings, 0 replies; 5+ messages in thread From: Dmitry Gutov @ 2013-06-17 17:42 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel On 17.06.2013 18:32, Stefan Monnier wrote: >>>> Is using emacs-lisp-mode here necessary? >>> No. Can you make it a bug-report, please (or install a patch which >>> just makes it use the emacs-lisp-mode syntax-table, since that's all >>> that matters)? >> Sure, installed. > > Actually, that was silly: since the code just uses `read' it doesn't > even need the syntax table (all this is because of some earlier code > I used which did need the syntax-table, and I didn't update my brain > according to the new code). That makes sense. Initially, I just commented emacs-lisp-mode call out, and the function worked fine, but I figured there could be some edge cases, etc. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-17 17:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1UnKYz-00063L-5u@vcs.savannah.gnu.org>
2013-06-16 17:07 ` trunk r112980: * lisp/emacs-lisp/package.el: Don't recompute dir. Use pkg-descs more Dmitry Gutov
2013-06-16 23:19 ` Stefan Monnier
2013-06-17 6:26 ` Dmitry Gutov
2013-06-17 14:32 ` Stefan Monnier
2013-06-17 17:42 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).