From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion'. Date: Fri, 10 May 2013 00:35:21 +0400 Message-ID: <518C0889.8000709@yandex.ru> References: <87vc6yz9r4.fsf@yandex.ru> <51861D6D.8030709@yandex.ru> <518718E4.3090108@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1368132087 31843 80.91.229.3 (9 May 2013 20:41:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 May 2013 20:41:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 09 22:41:26 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UaXeX-00086h-7d for ged-emacs-devel@m.gmane.org; Thu, 09 May 2013 22:41:25 +0200 Original-Received: from localhost ([::1]:38038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaXeW-0005vF-IA for ged-emacs-devel@m.gmane.org; Thu, 09 May 2013 16:41:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaXeP-0005ud-Rf for emacs-devel@gnu.org; Thu, 09 May 2013 16:41:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaXeL-0005LG-Tm for emacs-devel@gnu.org; Thu, 09 May 2013 16:41:17 -0400 Original-Received: from mail-la0-x22d.google.com ([2a00:1450:4010:c03::22d]:54756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaXYg-0003hJ-Iq for emacs-devel@gnu.org; Thu, 09 May 2013 16:35:22 -0400 Original-Received: by mail-la0-f45.google.com with SMTP id fp12so3322246lab.32 for ; Thu, 09 May 2013 13:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding:x-antivirus:x-antivirus-status; bh=3u/RG423OHxqPkdakrmw14/7pA/QbLs7htJ2dVed9lM=; b=N1gk9dd77A5q1zVFQ1uHuUyP24i5H+GVNKaz4OczzGvNrBDr64jBVb1igulSB6+AJT 8V/4CvDaDm+OrJ4t3bqBXEKgSKufvgdrCGNWGNr2xG58XB/vBu/T9noNlbaO82I932yN SvN3CJJIIGJYrumB7GIY3gJpNye86QudHHslcy+2otwk0O5ad297G5iEEquFxf9FWz7U D+5Acqjlov4T0v5CD6/MQoYZ46OgAcsC/eC40/hw6kRClWjjWP2GwZECADp4A2Bs7z2Z LavAQLEBCVRqSMtcUrYbBwuAZOCJ7ZuEVCPERJijXna5W5HSy0dXjlPQBxJ2Sw0aMMNa bfYQ== X-Received: by 10.112.145.7 with SMTP id sq7mr2864505lbb.20.1368131721227; Thu, 09 May 2013 13:35:21 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id jr19sm1613982lab.0.2013.05.09.13.35.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 09 May 2013 13:35:19 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 In-Reply-To: X-Antivirus: avast! (VPS 130509-0, 09.05.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159456 Archived-At: On 06.05.2013 7:22, Stefan Monnier wrote: >>>>>> Like the header in company.el says, we still try to support Emacs 22 and >>>>>> 23. `pcase' was only added in 23.3, I believe. >>>>> But this is in a comment, so it's not a problem. >>>> I'm not sure recommending to users to write new backends in a way >>>> incompatible with older Emacs is good. >>> It is in my interest to encourage all users to move to a more >>> recent Emacs. >> I still don't like the dissonance between the "Compatibility" header and >> this recommendation, not far below it. But if you insist, let's keep it >> that way. > > I definitely do not insist on it. I just explain why I committed the > code this way. But as maintainer of company, you're free to make > a different decision. Ok, thanks. I reverted this and the other bit that explicitly required lexical binding. I'll be sure to bring them back when we say goodbye to Emacs 23. >> package.el doesn't have an easy way to install a non-latest version >> of a package, so it will affect any users with old Emacs who are updating or >> reinstalling the package. Provided they sometimes use `company-begin-with', >> of course. > > GNU ELPA is mostly meant for Emacs>=24. We don't actively try to > prevent users of Emacs<24 from using GNU ELPA, but several of GNU ELPA > packages only work in Emacs>=24. That just means that discontinuing support for Emacs 23 is allowed. > We can/should add a package-require for (emacs "24.1") or whichever > version is needed, so that package.el won't automatically upgrade to > a package that doesn't work in the currently running Emacs. Sure. js2-mode, for example, already does that.