From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Build failure from trunk Date: Wed, 08 May 2013 07:46:50 -0700 Organization: UCLA Computer Science Department Message-ID: <518A655A.4080508@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1368024422 8089 80.91.229.3 (8 May 2013 14:47:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 May 2013 14:47:02 +0000 (UTC) Cc: Matthew Leach , emacs-devel@gnu.org To: =?UTF-8?B?SmFuIERqw6Rydg==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 08 16:46:59 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ua5dz-0001Px-56 for ged-emacs-devel@m.gmane.org; Wed, 08 May 2013 16:46:59 +0200 Original-Received: from localhost ([::1]:53866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua5dy-0005Wj-JV for ged-emacs-devel@m.gmane.org; Wed, 08 May 2013 10:46:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua5dt-0005TR-Qm for emacs-devel@gnu.org; Wed, 08 May 2013 10:46:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ua5ds-0003VJ-Kg for emacs-devel@gnu.org; Wed, 08 May 2013 10:46:53 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:41883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua5ds-0003V0-F9 for emacs-devel@gnu.org; Wed, 08 May 2013 10:46:52 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id AD21239E8108; Wed, 8 May 2013 07:46:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CZF8+pYLHcRZ; Wed, 8 May 2013 07:46:50 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-71-189-154-249.lsanca.fios.verizon.net [71.189.154.249]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4333339E8100; Wed, 8 May 2013 07:46:50 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159430 Archived-At: On 05/07/2013 10:06 PM, Jan Dj=C3=A4rv wrote: > #if !defined USE_GTK || GTK_MAJOR_VERSION < 3 + (GTK_MINOR_VERSION < 4) >=20 > This will be true for Gtk 4.0 to 4.3, 5.0 to 5.3, 6.0 to 6.3 and so on,= so it is obviously not correct. Sorry, I don't see the bug. Perhaps you misread the "+" as "|"? For 4.0, for example, GTK_MAJOR_VERSION is 4 and GTK_MINOR_VERSION is 0, so the comparison evaluates to 4 < 3 + (0 < 4), which is false, which is what is wanted here.