From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion'. Date: Mon, 06 May 2013 06:43:48 +0400 Message-ID: <518718E4.3090108@yandex.ru> References: <87vc6yz9r4.fsf@yandex.ru> <51861D6D.8030709@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1367808239 32479 80.91.229.3 (6 May 2013 02:43:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 May 2013 02:43:59 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 06 04:43:58 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UZBPB-0001eP-W0 for ged-emacs-devel@m.gmane.org; Mon, 06 May 2013 04:43:58 +0200 Original-Received: from localhost ([::1]:47491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZBPB-0001S4-H5 for ged-emacs-devel@m.gmane.org; Sun, 05 May 2013 22:43:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZBP4-0001Rz-Nk for emacs-devel@gnu.org; Sun, 05 May 2013 22:43:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZBP0-0003PC-1Z for emacs-devel@gnu.org; Sun, 05 May 2013 22:43:50 -0400 Original-Received: from mail-la0-x232.google.com ([2a00:1450:4010:c03::232]:58791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZBOz-0003P0-Qe for emacs-devel@gnu.org; Sun, 05 May 2013 22:43:45 -0400 Original-Received: by mail-la0-f50.google.com with SMTP id fl20so2940570lab.9 for ; Sun, 05 May 2013 19:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding:x-antivirus:x-antivirus-status; bh=ZBKwdwtACoCVQAaPQJYwWsLw33bR5jBB9xGPGn+ayVo=; b=zYVuObYVS+gfZ84f4nrPGzNUIIp27YwI1yLdeEAYjI47zRrWSVdkzDGxCB+am999en zyoTBPOkaTbPyTUlpCrrHJXNTUxCt9vtOt3b/1S0FLQf6LG6EqvW6sem68bSZs3tPVYy BICr2t5BpUpTgJUOtYly7HPXu/ww6xCGSNSyCy1cIQS5QLJLHykffrUHQNdpgX2CLapE cct4OTcwnH9yM5+OYWvB3AD3GIKgvZBRVViAlB2rq19GknB1SDDLhr8yZcYyH1bYqmCz 9WCTyeeRf/qMnFgRnaPrJ9rNTgEl3TUr8ljw0EJM5pAx8hdaYGSZTIl1NSQ3zZsSKWDv 4IiA== X-Received: by 10.112.180.232 with SMTP id dr8mr230873lbc.67.1367808224710; Sun, 05 May 2013 19:43:44 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id r9sm7852107lbr.3.2013.05.05.19.43.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 05 May 2013 19:43:43 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 In-Reply-To: X-Antivirus: avast! (VPS 130505-1, 05.05.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159357 Archived-At: On 06.05.2013 5:18, Stefan Monnier wrote: >>>> Like the header in company.el says, we still try to support Emacs 22 and >>>> 23. `pcase' was only added in 23.3, I believe. >>> But this is in a comment, so it's not a problem. >> I'm not sure recommending to users to write new backends in a way >> incompatible with older Emacs is good. > > It is in my interest to encourage all users to move to a more > recent Emacs. I still don't like the dissonance between the "Compatibility" header and this recommendation, not far below it. But if you insist, let's keep it that way. There are other reasons to install the latest Emacs, like packages using Emacs-24-only features. It doesn't seem to me that Company can really benefit from many of those, so far. > And even more so to encourage them to move away from `cl' > (which will be a long and arduous path, so every bit helps). While we're on the subject of `cl', why not use `cl-lib' and `cl-case'? I seriously doubt any backend will be able to use the additional features provided by `pcase'. > There are many ways to do initialization in the backend (once per > session, once per buffer, once per blue moon, you name it) without using > `init'. I guess that is true. And if you're just arguing against having a similar field in `completion-extra-properties', I'm fine with that. >> This is totally fine for `company-capf', but `company-begin-with' is an old >> function/feature. > > But I'm only suggesting to change it in more recent versions of Company, > so it won't affect old users. That doesn't make sense. Keeping compatibility with Emacs < 24 by definition means not breaking it in the latest version. package.el doesn't have an easy way to install a non-latest version of a package, so it will affect any users with old Emacs who are updating or reinstalling the package. Provided they sometimes use `company-begin-with', of course.