unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion'.
Date: Mon, 06 May 2013 06:43:48 +0400	[thread overview]
Message-ID: <518718E4.3090108@yandex.ru> (raw)
In-Reply-To: <jwvip2wkj3q.fsf-monnier+emacs@gnu.org>

On 06.05.2013 5:18, Stefan Monnier wrote:
>>>> Like the header in company.el says, we still try to support Emacs 22 and
>>>> 23. `pcase' was only added in 23.3, I believe.
>>> But this is in a comment, so it's not a problem.
>> I'm not sure recommending to users to write new backends in a way
>> incompatible with older Emacs is good.
>
> It is in my interest to encourage all users to move to a more
> recent Emacs.

I still don't like the dissonance between the "Compatibility" header and 
this recommendation, not far below it. But if you insist, let's keep it 
that way.

There are other reasons to install the latest Emacs, like packages using 
Emacs-24-only features. It doesn't seem to me that Company can really 
benefit from many of those, so far.

> And even more so to encourage them to move away from `cl'
> (which will be a long and arduous path, so every bit helps).

While we're on the subject of `cl', why not use `cl-lib' and `cl-case'? 
I seriously doubt any backend will be able to use the additional 
features provided by `pcase'.

> There are many ways to do initialization in the backend (once per
> session, once per buffer, once per blue moon, you name it) without using
> `init'.

I guess that is true. And if you're just arguing against having a 
similar field in `completion-extra-properties', I'm fine with that.

>> This is totally fine for `company-capf', but `company-begin-with' is an old
>> function/feature.
>
> But I'm only suggesting to change it in more recent versions of Company,
> so it won't affect old users.

That doesn't make sense. Keeping compatibility with Emacs < 24 by 
definition means not breaking it in the latest version.

package.el doesn't have an easy way to install a non-latest version of a 
package, so it will affect any users with old Emacs who are updating or 
reinstalling the package. Provided they sometimes use 
`company-begin-with', of course.



  reply	other threads:[~2013-05-06  2:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1UW5x9-0001hw-8W@vcs.savannah.gnu.org>
2013-05-04 21:59 ` /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion' Dmitry Gutov
2013-05-05  6:32   ` Stefan Monnier
2013-05-05  8:50     ` Dmitry Gutov
2013-05-05 10:05       ` Sebastian Wiesner
2013-05-05 10:13         ` Dmitry Gutov
2013-05-06  1:18       ` Stefan Monnier
2013-05-06  2:43         ` Dmitry Gutov [this message]
2013-05-06  3:22           ` Stefan Monnier
2013-05-09 20:35             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518718E4.3090108@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).