From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Any exceptions for the 15-line rule? Date: Sat, 04 May 2013 09:27:05 +0400 Message-ID: <51849C29.2040201@yandex.ru> References: <87d2tgu0ad.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1367645239 4317 80.91.229.3 (4 May 2013 05:27:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 May 2013 05:27:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 04 07:27:17 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UYV09-0000Hg-Bh for ged-emacs-devel@m.gmane.org; Sat, 04 May 2013 07:27:17 +0200 Original-Received: from localhost ([::1]:37037 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYV08-00019I-U9 for ged-emacs-devel@m.gmane.org; Sat, 04 May 2013 01:27:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYV02-00018I-5V for emacs-devel@gnu.org; Sat, 04 May 2013 01:27:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYUzy-0006xa-Fa for emacs-devel@gnu.org; Sat, 04 May 2013 01:27:10 -0400 Original-Received: from mail-lb0-f181.google.com ([209.85.217.181]:46127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYUzy-0006xQ-7I for emacs-devel@gnu.org; Sat, 04 May 2013 01:27:06 -0400 Original-Received: by mail-lb0-f181.google.com with SMTP id w10so2099897lbi.40 for ; Fri, 03 May 2013 22:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding:x-antivirus:x-antivirus-status; bh=86gXRk7Vv1y/Pm3/Zfnes2clx4ic+fwKti+D1MYW+wg=; b=G0hshobGxJOmUrk1JMqNtpW6WCCP4adtEux4nIlTMNmQO8zC5du4PFoqHfw1wYoVv6 O/X3/fnzCP91KQ8t4K8UYKFcRkiFDUAtn7I1piwyomX4TojUTzpzr1z0g7guOmB3KiJ/ yPm8rE27bh6i8/I52TJ4yngzZX7+aKp5/n0OnwgjuE2nbaTuQpMmYvQrvdjvTp1JGa/S TcrpTKQH1sgRGJWEmoy02wXs4C5aok0VC/QBuWE9k7/G5AdnY1DXzI4Y1hgyuq0d4SK5 5og/8nisk3UBv+TOrGcEhJLXojZ3JGHikzxy+4t6JItQdQWLx6jgGGEyXfHBE3ZI35CR pQ0Q== X-Received: by 10.152.87.39 with SMTP id u7mr5111170laz.48.1367645224831; Fri, 03 May 2013 22:27:04 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id rp6sm5102745lbb.7.2013.05.03.22.27.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 03 May 2013 22:27:03 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 In-Reply-To: X-Antivirus: avast! (VPS 130503-1, 03.05.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.217.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159282 Archived-At: On 27.04.2013 8:41, Stefan Monnier wrote: >> The latter is licensed under GPLv3+, but I'm pretty sure the author >> (brianjcj AT gmail, not sure what's his full name) has not signed the >> CA. And I'm not wild about the idea of waiting several months to add the >> feature (that is, if the author even agrees to sign the CA). > > The change includes > > - (with-temp-buffer > + (buf (get-buffer-create "*clang-output*")) > + (with-current-buffer buf (erase-buffer)) > + (with-current-buffer buf > > Which seems like it's making the code worse rather than better. > If you undo this undesirable part of the patch, it'll be closer to > the acceptable limit. So, I've merged the patch into Git repo with some modifications, but looks like the above change is perfectly justified: the new code uses `call-process-region', which takes the region from the current buffer, so using it with `with-temp-buffer' doesn't seem possible.