From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Any exceptions for the 15-line rule? Date: Thu, 02 May 2013 00:37:04 +0400 Message-ID: <51817CF0.5070902@yandex.ru> References: <87d2tgu0ad.fsf@yandex.ru> <871u9wyxaz.fsf@yandex.ru> <517BD66C.8030906@yandex.ru> <8761z31dv4.fsf@yandex.ru> <518155CF.30202@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1367440650 22255 80.91.229.3 (1 May 2013 20:37:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 1 May 2013 20:37:30 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 01 22:37:29 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UXdmH-0000o9-DV for ged-emacs-devel@m.gmane.org; Wed, 01 May 2013 22:37:25 +0200 Original-Received: from localhost ([::1]:38528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXdmH-0002iu-2A for ged-emacs-devel@m.gmane.org; Wed, 01 May 2013 16:37:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXdmA-0002ip-Io for emacs-devel@gnu.org; Wed, 01 May 2013 16:37:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXdm6-0002n1-MI for emacs-devel@gnu.org; Wed, 01 May 2013 16:37:18 -0400 Original-Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:39655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXdly-0002ll-Nu; Wed, 01 May 2013 16:37:06 -0400 Original-Received: by mail-la0-f53.google.com with SMTP id eg20so1612240lab.26 for ; Wed, 01 May 2013 13:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding:x-antivirus:x-antivirus-status; bh=ElRvDqf2Uk/ph77WuJQ4Ki36JVBoSsT6AI/o9b+lf5w=; b=07rzSAu2AO7/DX333kGzp8dphmK9GLh4cKFMM0vbHWr3UnJCyX9pkW50Y/UOAanNwg 1nC9ht02C7BW5zCTkjOrLFIabwRgh3uJtEag69SuL1GFQ0Xlf1zihHUjhHwWbfxWNfDf OxZK582AgiquvZhqcSyBp1q7r6TpOOfSOFLx1vRpUBmFSdqb0gw6symnF9PfR3jy6uHu IbXXsEAZ6gfWdZSD/jkh3ygx7tFGxtP3RKtuTn2LvJusA8l+rXNceJY+y86C4lg7trug eG9G60u3ehOIeJfcGSU059wtULX6ofaovXLLjLp8uSS8ne3ASsM0Y85sYyCAoB6hzSj6 XBnw== X-Received: by 10.112.72.97 with SMTP id c1mr1663918lbv.96.1367440625586; Wed, 01 May 2013 13:37:05 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id c15sm1749894lbj.17.2013.05.01.13.37.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 01 May 2013 13:37:04 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 In-Reply-To: X-Antivirus: avast! (VPS 130501-0, 01.05.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159257 Archived-At: On 01.05.2013 22:06, Glenn Morris wrote: > Dmitry Gutov wrote: > >> Thank you. I don't think I've seen a good definition of "tiny change" >> anywhere, and there's no s/foo/bar in either of these patches, but if >> you suggest to use my own judgment, that's fine by me. > > s/foo/bar was just an example. > > You need to look at the change and ask, "conceptually, how big is this"? > Deleting says 15 lines of common code from two places and turning it > into a separate function that those two places call only "counts" as a > few lines IMO (the function definition part, the function body is the > same code as before, just moved around). I see, that's good. The two function invocations should probably also count, as +1 or +2. What about the second patch? https://github.com/mooz/js2-mode/pull/100.diff Should it be counted as just +3 (for the added docstring), or does the tweaked list of identifiers also contribute? I'm thinking no, because the change only removes elements from the list. What if the diff was adding new elements (like the reverse of this diff would do)? Would I be able to discount those lines then, on the basis that this is just copying information from the specification?