From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-15?Q?Andreas_R=F6hler?= Newsgroups: gmane.emacs.devel Subject: Re: About commit style Date: Sat, 06 Apr 2013 17:46:48 +0200 Message-ID: <51604368.1050902@online.de> References: <20130406161308.f195518200567a56f123ac05@gmail.com> <83d2u8dorn.fsf@gnu.org> <831uanem8l.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1365278431 27116 80.91.229.3 (6 Apr 2013 20:00:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Apr 2013 20:00:31 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 22:00:33 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOZHg-0007UX-Vk for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 22:00:21 +0200 Original-Received: from localhost ([::1]:53259 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOVJr-00080e-6Z for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 11:46:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOVJ1-0007AF-EO for emacs-devel@gnu.org; Sat, 06 Apr 2013 11:45:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOVIz-0004NF-RT for emacs-devel@gnu.org; Sat, 06 Apr 2013 11:45:27 -0400 Original-Received: from moutng.kundenserver.de ([212.227.126.171]:52155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOVIz-0004Mh-IX for emacs-devel@gnu.org; Sat, 06 Apr 2013 11:45:25 -0400 Original-Received: from [192.168.178.21] (brln-4d0c39d4.pool.mediaWays.net [77.12.57.212]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0Lr4CZ-1V34uf3hKd-00eZ1G; Sat, 06 Apr 2013 17:45:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 In-Reply-To: X-Provags-ID: V02:K0:3L6UYVZNxJ1njmab6vS0qWMjqFD0d9q/EGK/UXARoZu AVcmRo+2acyE3G1FI4iHPbEAyG5QrpGU/2LaGnD1o5/x+qBUMT ByKBe0jxmm2Jds0iLnhYph9bdKSbBEfvXUKdY4QwjQKHUZOR+d s1kzXv4U5oiZBKJ6xR2iCwsfWGgmY42mBqRGNInNf7qNAD828f GJ2w7MoNWnrHoqOjUXkxPHibGXVvdKc5i0063gYF95EoaSB48H TS6DtzA9Qj2zCKOHXQBc9PyjNZMFjZ6fj6gJ2h31fWQJHyvl+5 0fHtWVPsRKHF6dDRUFQrZ1urz7FNAd/Yc6kgyCP73xyHjtHiLo Qu7BX4dzDoETe0dUSS4A= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.126.171 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158687 Archived-At: Am 06.04.2013 17:32, schrieb Stefan Monnier: >>>> Then fix the bugs (one by one, if they are different) >>> If they're trivial enough, it's perfectly OK to lump them together. >> What are "trivial bugs" in this context? Something beyond typos and >> whitespace changes? > > Bugs which are due to using "just not quite the right code". > E.g. renaming a function/variable to use a proper prefix. > > > Stefan > > Just for completeness it might pay to consider the case of a re-write too. It must neither fix a bug nor introduce new features but might affect a bunch of lines. During such a re-write a couple of steps deserve notice, while some of them will turn out not so useful, being revoked before final commit. Andreas