From: "Andreas Röhler" <andreas.roehler@online.de>
To: emacs-devel@gnu.org
Subject: Re: About commit style
Date: Sat, 06 Apr 2013 17:46:48 +0200 [thread overview]
Message-ID: <51604368.1050902@online.de> (raw)
In-Reply-To: <jwv1uan4qy1.fsf-monnier+emacs@gnu.org>
Am 06.04.2013 17:32, schrieb Stefan Monnier:
>>>> Then fix the bugs (one by one, if they are different)
>>> If they're trivial enough, it's perfectly OK to lump them together.
>> What are "trivial bugs" in this context? Something beyond typos and
>> whitespace changes?
>
> Bugs which are due to using "just not quite the right code".
> E.g. renaming a function/variable to use a proper prefix.
>
>
> Stefan
>
>
Just for completeness it might pay to consider the case of a re-write too.
It must neither fix a bug nor introduce new features but might affect a bunch of lines.
During such a re-write a couple of steps deserve notice, while some of them will turn
out not so useful, being revoked before final commit.
Andreas
next prev parent reply other threads:[~2013-04-06 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 8:13 About commit style Xue Fuqiao
2013-04-06 8:52 ` Eli Zaretskii
2013-04-06 9:08 ` Eli Zaretskii
2013-04-06 11:03 ` Xue Fuqiao
2013-04-06 13:10 ` Stefan Monnier
2013-04-06 15:02 ` Eli Zaretskii
2013-04-06 15:32 ` Stefan Monnier
2013-04-06 15:46 ` Andreas Röhler [this message]
2013-04-07 6:17 ` Xue Fuqiao
2013-04-07 15:41 ` Eli Zaretskii
2013-04-07 15:48 ` Stefan Monnier
2013-04-07 22:22 ` Xue Fuqiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51604368.1050902@online.de \
--to=andreas.roehler@online.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).