unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Andreas Röhler" <andreas.roehler@online.de>
To: emacs-devel@gnu.org
Cc: Leo <sdl.web@gmail.com>
Subject: Re: /srv/bzr/emacs/trunk r112183: Move forward-whitespace, forward-symbol,  forward-same-syntax commands to subr.el. Use forward-symbol in supermode.el again.
Date: Sun, 31 Mar 2013 10:39:20 +0200	[thread overview]
Message-ID: <5157F638.6020800@online.de> (raw)
In-Reply-To: <m162083xxt.fsf@gmail.com>

Am 31.03.2013 08:06, schrieb Leo Liu:
> On 2013-03-30 20:10 +0800, Ted Zlatanov wrote:
>> http://permalink.gmane.org/gmane.emacs.devel/158448
>>
>> Stefan advised it for `forward-symbol' and after looking at
>> `thingatpt.el', I agreed with him.  The other two (`forward-same-syntax'
>> and `forward-whitespace') were very similar so I followed the same
>> logic:
>>
>> 1) simple, generally useful, small
>>
>> 2) use only basic Emacs commands and no commands from `thingatpt.el'
>>
>> 3) seem consistent with the rest of `subr.el'
>>
>> Perhaps we can have `motion.el' or something, but with the current
>> layout `subr.el' seems the best place.
>
> You already have a nice and broad name space to work with i.e. thingatpt
> so no need to make another one. thingatpt gives you forward and backward
> motions and other goodies.


Hi Leo,

thingatpt.el delivers a framework, an unified way to determine the start and the end of an object in buffer.

Upon that identifications some simple commands are implemented there, which make use of it: jumps-to-start, -end, move-over etc.

The commands moved now are simple commands also with a related purpose but not constructed upon the thingatpt framework.

Not everything with wheels needs to be exposed during an car-saloon ;)

Best,

Andreas



>
> I think a better and cleaner way to do this is maybe clean up
> thingatpt.el. Now codes are scattered everywhere which is messier in my
> book.
>
> Leo
>
>




  reply	other threads:[~2013-03-31  8:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1ULlM5-0005j5-2R@vcs.savannah.gnu.org>
2013-03-30  5:04 ` /srv/bzr/emacs/trunk r112183: Move forward-whitespace, forward-symbol, forward-same-syntax commands to subr.el. Use forward-symbol in supermode.el again Leo Liu
2013-03-30  7:07   ` Andreas Röhler
2013-03-30  7:41     ` Leo Liu
2013-03-30  8:07       ` Andreas Röhler
2013-03-30  8:40       ` Eli Zaretskii
2013-03-30  9:54         ` Leo Liu
2013-03-30 10:21           ` Eli Zaretskii
2013-03-30 12:10   ` Ted Zlatanov
2013-03-31  6:06     ` Leo Liu
2013-03-31  8:39       ` Andreas Röhler [this message]
2013-03-31 12:10       ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5157F638.6020800@online.de \
    --to=andreas.roehler@online.de \
    --cc=emacs-devel@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).