unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Hard bug caused by window management code?
Date: Wed, 27 Mar 2013 11:02:52 +0100	[thread overview]
Message-ID: <5152C3CC.8050500@gmx.at> (raw)
In-Reply-To: <5152BB48.10700@yandex.ru>

 >> It seems to hang in `set-window-configuration'.

Could you confirm that?

 > Now I'm seeing that enormously huge SIZE (3151760 !!!) passed from Lisp
 > to Fset_window_new_total

This could come from the following line in delete_all_child_windows

   wset_total_lines (w, w->buffer);

which is later on used as

	  if (BUFFERP (w->total_lines))
	    wset_buffer (w, w->total_lines);

in `set-window-configuration' and escaped my understanding ever since.
Note the "Kludge Alert" there.

 > causes an attempt to allocate appropriately huge
 > glyph matrix (window_resize_apply propagates this value from w->new_total
 > to w->total_lines, next it's used in window_box_height, and finally in
 > required_matrix_height, etc.). So:
 >
 > 1) Can you check lisp/window.el and find from where this SIZE comes?

See above.  I do not have any other clues.

 > 2) Shouldn't we check whether SIZE in Fset_window_new_total and

This would be _usually_ caught by window_resize_check.  But note that
`set-window-configuration' is special in this regard.

 >    Fset_window_new_normal isn't too large,

This is a float and should by always <= 1.  Any wrong value here should
never have grave implications like the one you observed.

 > for example, not larger
 >    than the appropriate dimension of the frame contains WINDOW?

martin



  reply	other threads:[~2013-03-27 10:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  6:11 Hard bug caused by window management code? Dmitry Antipov
2013-03-27  7:07 ` Eli Zaretskii
2013-03-27  7:23 ` martin rudalics
2013-03-27  9:26   ` Dmitry Antipov
2013-03-27 10:02     ` martin rudalics [this message]
2013-03-27 10:39       ` Dmitry Antipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5152C3CC.8050500@gmx.at \
    --to=rudalics@gmx.at \
    --cc=dmantipov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).