From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: schwab@linux-m68k.org,
"René Kyllingstad" <listmailemacs@kyllingstad.com>,
monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards
Date: Mon, 25 Mar 2013 09:30:26 -0700 [thread overview]
Message-ID: <51507BA2.6070907@cs.ucla.edu> (raw)
In-Reply-To: <83li9b1nu2.fsf@gnu.org>
On 03/25/13 08:49, Eli Zaretskii wrote:
> Andreas didn't change any code like this:
>
> if (0 < i && i < N)
I'm afraid that he did change some range-checking code
like that. The actual code was more complicated (the part
before the && was a conditional), but it was definitely
using that style before he changed it.
next prev parent reply other threads:[~2013-03-25 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 15:38 [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards René Kyllingstad
2013-03-25 15:49 ` Eli Zaretskii
2013-03-25 16:30 ` Paul Eggert [this message]
2013-03-26 13:56 ` James Cloos
[not found] <E1UJknW-0004ja-JF@vcs.savannah.gnu.org>
2013-03-25 14:06 ` Stefan Monnier
2013-03-25 14:32 ` Andreas Schwab
2013-03-26 14:21 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51507BA2.6070907@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=listmailemacs@kyllingstad.com \
--cc=monnier@iro.umontreal.ca \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).