unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Colascione <dancol@dancol.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: [RFC] refactoring DEFUN
Date: Mon, 25 Mar 2013 06:18:38 -0700	[thread overview]
Message-ID: <51504EAE.9080402@dancol.org> (raw)
In-Reply-To: <51503B6D.1060203@yandex.ru>

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

On 3/25/2013 4:56 AM, Dmitry Antipov wrote:
> Although C preprocessor can't transform the text too much, it's
> still possible to use concatenation to avoid silly typing like:
> 
> DEFUN ("foo", Ffoo, Sfoo, ...)
> 

I really don't mind the way it is now. Adding a subr isn't a particularly common
endeavor.

> and use:
> 
> DEFUN ("foo", foo, ...)
> 
> instead. The core change is simple, but the obvious rest is ~450K
> uncompressed (99.9% was generated by elisp program, BTW).

I'd prefer to keep it the old way --- it preserves greppability. The new way
involves a lot more magic, and I don't think it buys us much maintainability
because changing buildin function names is rare.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2013-03-25 13:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 11:56 [RFC] refactoring DEFUN Dmitry Antipov
2013-03-25 12:19 ` Eli Zaretskii
2013-03-25 12:38   ` Eli Zaretskii
2013-03-25 12:56   ` Andy Moreton
2013-03-25 12:55 ` Andy Moreton
2013-03-25 13:48   ` Dmitry Antipov
2013-03-25 13:18 ` Daniel Colascione [this message]
2013-03-25 14:02   ` [RFC] " Dmitry Antipov
2013-03-25 13:54 ` Alan Mackenzie
2013-03-25 14:34 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51504EAE.9080402@dancol.org \
    --to=dancol@dancol.org \
    --cc=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).