* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112051: Optimize ASCII file reading with EOL format detection and decoding.
[not found] <E1UGXK1-0007wN-J8@vcs.savannah.gnu.org>
@ 2013-03-15 18:34 ` Juanma Barranquero
2013-03-15 20:06 ` Paul Eggert
0 siblings, 1 reply; 2+ messages in thread
From: Juanma Barranquero @ 2013-03-15 18:34 UTC (permalink / raw)
To: K. Handa; +Cc: Emacs developers
On Fri, Mar 15, 2013 at 5:06 PM, K. Handa <handa@gnu.org> wrote:
> + if (coding->eol_seen == EOL_SEEN_CR)
> + {
> + unsigned char *src_end = GAP_END_ADDR;
> + unsigned char *src = src - coding->src_bytes;
Is that supposed to be
> + unsigned char *src = src_end - coding->src_bytes;
?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112051: Optimize ASCII file reading with EOL format detection and decoding.
2013-03-15 18:34 ` [Emacs-diffs] /srv/bzr/emacs/trunk r112051: Optimize ASCII file reading with EOL format detection and decoding Juanma Barranquero
@ 2013-03-15 20:06 ` Paul Eggert
0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2013-03-15 20:06 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: K. Handa, Emacs developers
Thanks, Juanma, I discovered that typo as well,
and fixed it in the trunk as you suggested.
I caught the typo by using "./configure --enable-gcc-warnings",
a practice that's saved me a lot of grief in the past.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-15 20:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1UGXK1-0007wN-J8@vcs.savannah.gnu.org>
2013-03-15 18:34 ` [Emacs-diffs] /srv/bzr/emacs/trunk r112051: Optimize ASCII file reading with EOL format detection and decoding Juanma Barranquero
2013-03-15 20:06 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).