* bidi_fetch_char
@ 2013-03-07 9:55 Dmitry Antipov
2013-03-07 10:12 ` bidi_fetch_char Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Antipov @ 2013-03-07 9:55 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Emacs development discussions
I have a long-standing style question for you too :-).
Since a lot of functions (almost all markers-related, gap movement,
some stuff from composite.c and even from bidi.c) expects character
position first and byte position next, I would suggest to swap 1st
and 2nd arguments of bidi_fetch_char just for the sake of common
style.
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: bidi_fetch_char
2013-03-07 9:55 bidi_fetch_char Dmitry Antipov
@ 2013-03-07 10:12 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2013-03-07 10:12 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: emacs-devel
> Date: Thu, 07 Mar 2013 13:55:04 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> CC: Emacs development discussions <emacs-devel@gnu.org>
>
> Since a lot of functions (almost all markers-related, gap movement,
> some stuff from composite.c and even from bidi.c) expects character
> position first and byte position next, I would suggest to swap 1st
> and 2nd arguments of bidi_fetch_char just for the sake of common
> style.
I have no problem with such a change.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-07 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-07 9:55 bidi_fetch_char Dmitry Antipov
2013-03-07 10:12 ` bidi_fetch_char Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).