On 02/09/2013 01:33 AM, Eli Zaretskii wrote: > I'd use find_newline, since 2 out of 3 of its callers are > find_next_newline_no_quit and find_before_next_newline. OK, thanks, attached is a revised patch to do that. It also removes the confusing comments about carriage return, and identifies two or three more places where it's clearer to use memchr.