unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jan D." <jan.h.d@swipnet.se>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel Devel <emacs-devel@gnu.org>
Subject: Re: Coding system conversion error
Date: Mon, 14 Feb 2005 06:42:36 +0100	[thread overview]
Message-ID: <50e2f24c825ce097d2da5c2208fd5a91@swipnet.se> (raw)
In-Reply-To: <200502140102.KAA29430@etlken.m17n.org>


> I reconsidered this problem, and now I agree with you.  I
> was at first negative on signaling an error in
> lisp_data_to_selection_data because I was not sure it is
> safe to do that.  But, I found that Fsignal is already use
> in this function.  So, I've just installed these changes.
>
> 2005-02-14  Kenichi Handa  <handa@m17n.org>
>
> 	* coding.c (encode_coding_string): Always return a unibyte string.
> 	If NOCOPY is nonzero and there's no need of encoding, make STR
> 	unibyte directly.
>
> 	* xselect.c (lisp_data_to_selection_data): If OBJ is a non-ASCII
> 	multibyte string, signal an error instead of aborting.

The error message can be improved if you put it in 
x_handle_selection_request instead (lisp_data_to_selection_data is only 
called from there).  Then you can get the target_symbol in to the error 
text, which otherwise can be hard to know.

	Jan D.

  reply	other threads:[~2005-02-14  5:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <v93bwbhsql.fsf@marauder.physik.uni-ulm.de>
     [not found] ` <20050205170221.ZTBD24781.mxfep02.bredband.com@coolsville.localdomain>
     [not found]   ` <v9k6pmhpdt.fsf@marauder.physik.uni-ulm.de>
     [not found]     ` <738f9db09f1986269b8f5719d45d2dd5@swipnet.se>
     [not found]       ` <v9fz08eglp.fsf@marauder.physik.uni-ulm.de>
     [not found]         ` <v9oeewweoh.fsf@marauder.physik.uni-ulm.de>
     [not found]           ` <4207DAF0.6000204@swipnet.se>
2005-02-08 21:50             ` Coding system conversion error (was Re: abort in x_handle_selection_event when copying text) Jan D.
2005-02-08 23:38               ` Coding system conversion error Stefan Monnier
2005-02-10 20:11                 ` Jan D.
2005-02-10 20:17                   ` Stefan Monnier
2005-02-10 21:30                     ` Jan D.
2005-02-12  1:57                       ` Kenichi Handa
2005-02-12  7:36                         ` Jan D.
2005-02-12 14:34                           ` Kim F. Storm
2005-02-13  0:14                           ` Kenichi Handa
2005-02-13 14:23                             ` Kim F. Storm
2005-02-13 16:10                             ` Stefan Monnier
2005-02-14  1:02                               ` Kenichi Handa
2005-02-14  5:42                                 ` Jan D. [this message]
2005-02-14  6:15                                   ` Kenichi Handa
2005-02-12  8:37                   ` Richard Stallman
2005-02-12  2:01                 ` Kenichi Handa
2005-02-10  6:01               ` Coding system conversion error (was Re: abort in x_handle_selection_event when copying text) Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50e2f24c825ce097d2da5c2208fd5a91@swipnet.se \
    --to=jan.h.d@swipnet.se \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).