From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: master 583cb26 2/3: Improve accuracy in string-replace description (bug#43598) Date: Mon, 28 Sep 2020 09:49:47 -0700 (PDT) Message-ID: <50bea60b-b70b-4a80-b85b-0c9283a033de@default> References: <20200927124520.25321.62354@vcs0.savannah.gnu.org> <20200927124522.BA20F207E0@vcs0.savannah.gnu.org> <9B45E488-F245-4A94-A492-C60B617A734B@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40776"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?B?TWF0dGlhcyBFbmdkZWfDpXJk?= , Emacs developers To: John Yates , Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 28 18:51:29 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMwN5-000ATb-T0 for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Sep 2020 18:51:27 +0200 Original-Received: from localhost ([::1]:50646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMwN4-0008Fb-VU for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Sep 2020 12:51:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMwLc-0007Ip-G8 for emacs-devel@gnu.org; Mon, 28 Sep 2020 12:49:56 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:37586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMwLa-0002Xj-Dj for emacs-devel@gnu.org; Mon, 28 Sep 2020 12:49:55 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08SGnfjf193558; Mon, 28 Sep 2020 16:49:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=zxSLqeAiZBnaIX22jDcPusTYS7AcDMuaJLZvApH9EDs=; b=vDL+JXlLp+J9sElaYoRjQ+avoYC+GgpjlCwgjkfAax7qWTxjnPpbmX0OURyVIiKb0SlC FxCQzHHAfxQ3LJbK+zECjuoeUfn47swB3IHS6XYGMBBHVk84eqzzwT6Uj0KRSDqOgUQF 0WwIcIwoFd95PeeM+3CYdm8b7XXcRIgNvbSPSnoiAEcQ6A9Bd3EHp98xOsQ83jSq25Ej oNLG5YPzkug29z0ugK1XIWBtX1nVmhr2L7fs4mgWsM2G7OF9ngplFie8aQuzYLlD1uyY lRTL6MNj2eSzaEcFaZ9jWzfjjTpcmHYZ34DXAmcEAEk++oB2uKG+5KFJJqjc5FVzlapM rA== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 33swkkp5s1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 28 Sep 2020 16:49:51 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08SGkMXN085942; Mon, 28 Sep 2020 16:49:50 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 33tfhwgnac-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Sep 2020 16:49:50 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08SGnmuZ002399; Mon, 28 Sep 2020 16:49:48 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9758 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=861 bulkscore=0 phishscore=0 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009280130 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9758 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=875 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009280130 Received-SPF: pass client-ip=141.146.126.78; envelope-from=drew.adams@oracle.com; helo=aserp2120.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/28 11:41:06 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -56 X-Spam_score: -5.7 X-Spam_bar: ----- X-Spam_report: (-5.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.687, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.614, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256619 Archived-At: > Okay. Then how about >=20 > Return a string equal to @var{instring} with every occurence of > @var{fromstring} replaced by @var{tostring}. Return a new string equal... ____ But do we really need to say this now, for every function? In the past nondestructive was the default (implicit), and we called out destructive exceptions. I'm not saying we shouldn't, especially if it just means adding a "new" here or there. But if descriptions aren't somewhat consistent then we risk increasing confusion, rather than diminishing it. If we go out of our way to say here that the returned string is a new one, will we start saying that everywhere?