From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/emacs-24 r111116: eval-after-load fix Date: Fri, 04 Jan 2013 09:32:43 +0400 Message-ID: <50E6697B.3040006@yandex.ru> References: <878v8b839k.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1357277577 9007 80.91.229.3 (4 Jan 2013 05:32:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Jan 2013 05:32:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 04 06:33:14 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tqzu1-0005nK-On for ged-emacs-devel@m.gmane.org; Fri, 04 Jan 2013 06:33:09 +0100 Original-Received: from localhost ([::1]:36709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqztm-0006Fx-Gn for ged-emacs-devel@m.gmane.org; Fri, 04 Jan 2013 00:32:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqztg-0006Fe-KC for emacs-devel@gnu.org; Fri, 04 Jan 2013 00:32:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqztc-00056D-Mx for emacs-devel@gnu.org; Fri, 04 Jan 2013 00:32:48 -0500 Original-Received: from mail-la0-f51.google.com ([209.85.215.51]:62344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqztY-00055Y-9U; Fri, 04 Jan 2013 00:32:40 -0500 Original-Received: by mail-la0-f51.google.com with SMTP id fj20so9221700lab.38 for ; Thu, 03 Jan 2013 21:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=U52bRf7AktW/uCdLyjdALE/xTYGq4Em7RecBz1N/1bg=; b=HXajH1G/5mHB9apkZ0l1YLxoFhxrxeez3O09XS5Bcf+0cHGZHoRf3+0RfJRoU0kbTd Zq4Xc5vvF/2bjt+IF1hpA4SDop8IRNJj/afM4bd2nNI+tBauL2/tbxrbDXq9+rPC5WOk XULlwzPoHRsxenS3hIlKlfU/Q45T+DzpnjRtDCP5axzdAFW0UJl7y1ysbD45v60z2lyX Cyk4+5hSMIu2TjKfqVzKA5s8jVfJfUJCkudhu+aOmHn97LQc4Z0DozdeoHD6SFYj9CP9 U1Y4d7YQdDR10ShOgrW+OeZrpxWRydcRnxIU457S32a8zkGR0OXCPD9DxOVZebv29fh2 F3Zg== X-Received: by 10.112.40.104 with SMTP id w8mr21384520lbk.114.1357277559016; Thu, 03 Jan 2013 21:32:39 -0800 (PST) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPS id ja10sm19061337lab.6.2013.01.03.21.32.36 (version=SSLv3 cipher=OTHER); Thu, 03 Jan 2013 21:32:37 -0800 (PST) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.215.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156070 Archived-At: On 03.01.2013 5:38, Glenn Morris wrote: > Dmitry Gutov wrote: > >> I wonder, wouldn't it still make sense to purecopy the form, just not >> the list wrapping it? > > Maybe. (Personally, I doubt any of these purecopy calls have any > non-negligible effect.) Feel feel to tweak it in trunk. I'd maybe tweak it if I knew what to benchmark for. IIUC, adding stuff to purespace makes GC's job simpler, as it doesn't have to keep track of references to those objects. Is that the only supposed benefit? So, I would benchmark it with a simple loop that creates GC pressure, right? I don't need to measure the time the dumping during the build takes, for example?