From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: set-file-extended-attributes and backups Date: Fri, 21 Dec 2012 08:00:01 -0800 Message-ID: <50D48781.1050303@cs.ucla.edu> References: <83obhntq1m.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1356105630 12087 80.91.229.3 (21 Dec 2012 16:00:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Dec 2012 16:00:30 +0000 (UTC) Cc: Romain Francoise To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 21 17:00:44 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tm51d-0001di-78 for ged-emacs-devel@m.gmane.org; Fri, 21 Dec 2012 17:00:41 +0100 Original-Received: from localhost ([::1]:54160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm51P-0003uU-IC for ged-emacs-devel@m.gmane.org; Fri, 21 Dec 2012 11:00:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm51K-0003uB-1l for emacs-devel@gnu.org; Fri, 21 Dec 2012 11:00:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tm519-0004yd-Lc for emacs-devel@gnu.org; Fri, 21 Dec 2012 11:00:21 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:55029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm519-0004x6-GZ for emacs-devel@gnu.org; Fri, 21 Dec 2012 11:00:11 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 12B5C39E810A; Fri, 21 Dec 2012 08:00:07 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jb4VlyZ6XXbX; Fri, 21 Dec 2012 08:00:06 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 7EE4839E8108; Fri, 21 Dec 2012 08:00:06 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 In-Reply-To: <83obhntq1m.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:155731 Archived-At: On 12/21/12 06:53, Eli Zaretskii wrote: > I think this problem is not Windows-specific. So I'm asking here: > does it make sense to fail backup-buffer and backup-buffer-copy just > because set-file-extended-attributes fails? I think we should ignore > such errors On systems where ACLs can deny access to files, failing to copy an ACL can mean that the copy has more permissions than the original, no? Wouldn't that be a security problem? As I understand it, Windows ACLs can deny access, just as Posix ACLs can, so this issue is relevant on Windows too. The recently-added ACL code has some security holes in this area, doesn't it? It's copying file mode separately from copying ACLs. Surely the code should just copy ACLs, as there's a race condition now, where the file is temporarily exposed between the times the mode and the ACLs are copied.