From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: Two flaws in window.c Date: Thu, 18 Oct 2012 13:41:47 +0400 Message-ID: <507FCEDB.20605@yandex.ru> References: <507F76D9.3090505@yandex.ru> <507FC89C.30008@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020905040803040600090703" X-Trace: ger.gmane.org 1350553325 2194 80.91.229.3 (18 Oct 2012 09:42:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2012 09:42:05 +0000 (UTC) Cc: Emacs development discussions To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 18 11:42:09 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TOmcC-0005Y2-PJ for ged-emacs-devel@m.gmane.org; Thu, 18 Oct 2012 11:42:08 +0200 Original-Received: from localhost ([::1]:48608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOmc5-0003OH-Q2 for ged-emacs-devel@m.gmane.org; Thu, 18 Oct 2012 05:42:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOmc0-0003O0-Go for emacs-devel@gnu.org; Thu, 18 Oct 2012 05:42:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOmbz-0006iG-Ay for emacs-devel@gnu.org; Thu, 18 Oct 2012 05:41:56 -0400 Original-Received: from forward1.mail.yandex.net ([77.88.46.6]:45414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOmby-0006i1-JX for emacs-devel@gnu.org; Thu, 18 Oct 2012 05:41:55 -0400 Original-Received: from smtp1.mail.yandex.net (smtp1.mail.yandex.net [77.88.46.101]) by forward1.mail.yandex.net (Yandex) with ESMTP id 2538512429EA; Thu, 18 Oct 2012 13:41:50 +0400 (MSK) Original-Received: from smtp1.mail.yandex.net (localhost [127.0.0.1]) by smtp1.mail.yandex.net (Yandex) with ESMTP id F312DAA03A4; Thu, 18 Oct 2012 13:41:47 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp1.mail.yandex.net (nwsmtp/Yandex) with ESMTP id flPCGX7M-flP08ZjZ; Thu, 18 Oct 2012 13:41:47 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1350553307; bh=0XdKbZtio0tVrgjViH5neHfuo9zE6SSXJv0mmNaIGrk=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type; b=G8Ei9qGtMMVQFELGwV7miJgjUmabaUY50J4suiHsVDt6NFanfEJDzlQ+XTOjzUGEQ sjO9d+2UIibjj1EZva2nV96lCpHXi2tDYlk1G3vhEPdCBrSOXVjbT2FOs9USCTYvie oPCLWwIZ06NKrzkwg69bx4H7mPRkoq2MRWAPgUz8= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 In-Reply-To: <507FC89C.30008@gmx.at> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 77.88.46.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154406 Archived-At: This is a multi-part message in MIME format. --------------020905040803040600090703 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/18/2012 01:15 PM, martin rudalics wrote: > These should be fixed now. Thanks. > Do you have any more suggestions? The minor style suggestion is to move window-specific checks to window.h and use WINDOW_xxx_P macros in CHECK_xxx_WINDOW (attached). Dmitry --------------020905040803040600090703 Content-Type: text/plain; charset=UTF-8; name="window-macros.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="window-macros.patch" PT09IG1vZGlmaWVkIGZpbGUgJ3NyYy9saXNwLmgnCi0tLSBzcmMvbGlzcC5oCTIwMTItMTAt MTYgMDI6MjI6MjUgKzAwMDAKKysrIHNyYy9saXNwLmgJMjAxMi0xMC0xOCAwOTozMjo1NSAr MDAwMApAQCAtMTc0MiwyMCArMTc0Miw2IEBACiAjZGVmaW5lIENIRUNLX1dJTkRPV19DT05G SUdVUkFUSU9OKHgpIFwKICAgQ0hFQ0tfVFlQRSAoV0lORE9XX0NPTkZJR1VSQVRJT05QICh4 KSwgUXdpbmRvd19jb25maWd1cmF0aW9uX3AsIHgpCiAKLS8qIEEgd2luZG93IG9mIGFueSBz b3J0LCBsZWFmIG9yIGludGVyaW9yLCBpcyAidmFsaWQiIGlmIG9uZSBvZiBpdHMKLSAgIGJ1 ZmZlciwgdmNoaWxkLCBvciBoY2hpbGQgbWVtYmVycyBpcyBub24tbmlsLiAgKi8KLSNkZWZp bmUgQ0hFQ0tfVkFMSURfV0lORE9XKHgpCQkJCVwKLSAgQ0hFQ0tfVFlQRSAoV0lORE9XUCAo eCkJCQkJXAotCSAgICAgICYmICghTklMUCAoWFdJTkRPVyAoeCktPmJ1ZmZlcikJCVwKLQkJ ICB8fCAhTklMUCAoWFdJTkRPVyAoeCktPnZjaGlsZCkJXAotCQkgIHx8ICFOSUxQIChYV0lO RE9XICh4KS0+aGNoaWxkKSksCVwKLQkgICAgICBRd2luZG93X3ZhbGlkX3AsIHgpCi0KLS8q IEEgd2luZG93IGlzICJsaXZlIiBpZiBhbmQgb25seSBpZiBpdCBzaG93cyBhIGJ1ZmZlci4g ICovCi0jZGVmaW5lIENIRUNLX0xJVkVfV0lORE9XKHgpCQkJCQkJXAotICBDSEVDS19UWVBF IChXSU5ET1dQICh4KSAmJiAhTklMUCAoWFdJTkRPVyAoeCktPmJ1ZmZlciksCQlcCi0JICAg ICAgUXdpbmRvd19saXZlX3AsIHgpCi0KICNkZWZpbmUgQ0hFQ0tfUFJPQ0VTUyh4KSBcCiAg IENIRUNLX1RZUEUgKFBST0NFU1NQICh4KSwgUXByb2Nlc3NwLCB4KQogCgo9PT0gbW9kaWZp ZWQgZmlsZSAnc3JjL3dpbmRvdy5oJwotLS0gc3JjL3dpbmRvdy5oCTIwMTItMDktMjAgMDM6 MTA6NTIgKzAwMDAKKysrIHNyYy93aW5kb3cuaAkyMDEyLTEwLTE4IDA5OjMzOjM4ICswMDAw CkBAIC05NzAsMTEgKzk3MCwxOSBAQAogICAgICAgIHx8ICFOSUxQIChYV0lORE9XIChXSU5E T1cpLT52Y2hpbGQpCQlcCiAgICAgICAgfHwgIU5JTFAgKFhXSU5ET1cgKFdJTkRPVyktPmhj aGlsZCkpKQogCisvKiBBIHdpbmRvdyBvZiBhbnkgc29ydCwgbGVhZiBvciBpbnRlcmlvciwg aXMgInZhbGlkIiBpZiBvbmUKKyAgIG9mIGl0cyBidWZmZXIsIHZjaGlsZCwgb3IgaGNoaWxk IG1lbWJlcnMgaXMgbm9uLW5pbC4gICovCisjZGVmaW5lIENIRUNLX1ZBTElEX1dJTkRPVyhX SU5ET1cpCQkJCVwKKyAgQ0hFQ0tfVFlQRSAoV0lORE9XX1ZBTElEX1AgKFdJTkRPVyksIFF3 aW5kb3dfdmFsaWRfcCwgV0lORE9XKQogCiAvKiBWYWx1ZSBpcyBub24temVybyBpZiBXSU5E T1cgaXMgYSBsaXZlIHdpbmRvdy4gICovCiAjZGVmaW5lIFdJTkRPV19MSVZFX1AoV0lORE9X KQkJCQkJXAogICAoV0lORE9XUCAoV0lORE9XKSAmJiAhTklMUCAoWFdJTkRPVyAoV0lORE9X KS0+YnVmZmVyKSkKIAorLyogQSB3aW5kb3cgaXMgImxpdmUiIGlmIGFuZCBvbmx5IGlmIGl0 IHNob3dzIGEgYnVmZmVyLiAgKi8KKyNkZWZpbmUgQ0hFQ0tfTElWRV9XSU5ET1coV0lORE9X KQkJCQlcCisgIENIRUNLX1RZUEUgKFdJTkRPV19MSVZFX1AgKFdJTkRPVyksIFF3aW5kb3df bGl2ZV9wLCBXSU5ET1cpCisKIC8qIFRoZXNlIHVzZWQgdG8gYmUgaW4gbGlzcC5oLiAgKi8K IAogZXh0ZXJuIExpc3BfT2JqZWN0IFF3aW5kb3dwLCBRd2luZG93X2xpdmVfcDsKCg== --------------020905040803040600090703--