From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sun Yijiang Newsgroups: gmane.emacs.devel Subject: bookmark.el bug report Date: Mon, 28 Dec 2009 14:19:16 +0800 Message-ID: <5065e2900912272219y3734fc9fsdaee41167ef99ad7@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1261981181 28843 80.91.229.12 (28 Dec 2009 06:19:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2009 06:19:41 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 28 07:19:34 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NP8x4-0000F2-F5 for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2009 07:19:34 +0100 Original-Received: from localhost ([127.0.0.1]:46196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NP8x4-0008Nw-Ik for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2009 01:19:34 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NP8ww-0008NA-9n for emacs-devel@gnu.org; Mon, 28 Dec 2009 01:19:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NP8wp-0008Ih-Hu for emacs-devel@gnu.org; Mon, 28 Dec 2009 01:19:24 -0500 Original-Received: from [199.232.76.173] (port=37638 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NP8wp-0008IN-7q for emacs-devel@gnu.org; Mon, 28 Dec 2009 01:19:19 -0500 Original-Received: from mail-pw0-f47.google.com ([209.85.160.47]:33611) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NP8wp-0000Fl-2u for emacs-devel@gnu.org; Mon, 28 Dec 2009 01:19:19 -0500 Original-Received: by pwi1 with SMTP id 1so7247299pwi.26 for ; Sun, 27 Dec 2009 22:19:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=nhWWJ7gwcC7Ru2VaaHt0pq9I7IqI6tPBCY56TjwZOe8=; b=ms4ZCSjxgnTrKp6QdCEdaWxUv6dTP92e9Ov9rIb5VjVrJ7bBFKfZqgY+Ls1+ianFQf 7xkR1M0Xg2OGUriR7NNM7el42H98ZtBkSJSy22YxzCeO4b8ZKY7jSEhNExeXVl/jQ6tN lYNDtUfMKCVyYwX9e0yYc5mLE+/MvohUpg4SI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=kS2/D4nOYjUVl9p2640nLRU6mVE45dWJYUbpmqzuwnLFgM4cx18wB5K8znt9FC5lDq DzyDtcurzlgfPaq+n5tii0SzB0oUrPBojzRikfSEXTMQiGQr6SmBfhLZVOb5q72ktS8h tYLDqTxvSlKCD3i68f7w6DmXeVIGHtjXKp0n0= Original-Received: by 10.142.8.35 with SMTP id 35mr10438937wfh.30.1261981156088; Sun, 27 Dec 2009 22:19:16 -0800 (PST) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118846 Archived-At: `bookmark-bmenu-execute-deletions' is broken for quite some time.=A0 I think I've found the problem.=A0 When it calls `bookmark-bmenu-bookmark', the callee gets text property at `(line-begging-position)', which is incorrect in this context.=A0 Below is the patched code of=A0 `bookmark-bmenu-bookmark' that works for me: (defun bookmark-bmenu-bookmark () =A0 "Return the bookmark for this line in an interactive bookmark list buff= er." =A0 (when (bookmark-bmenu-check-position) =A0=A0=A0 (let ((pos (line-beginning-position))) =A0=A0=A0=A0=A0 (when (looking-back "^[^ ]") =A0=A0=A0=A0=A0=A0=A0 (setq pos (+ 1 pos))) =A0=A0=A0=A0=A0 (get-text-property pos 'bookmark-name-prop)))) Sincerely, Steve