From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Reimplement module functions Date: Sat, 20 May 2017 13:46:20 -0700 Organization: UCLA Computer Science Department Message-ID: <5057be0b-456d-e7d9-df36-7dc52e4b540c@cs.ucla.edu> References: <20170514180901.95283-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------987940A5A0E1E0ED63A76755" X-Trace: blaine.gmane.org 1495313196 15308 195.159.176.226 (20 May 2017 20:46:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 20 May 2017 20:46:36 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 Cc: Philipp Stephani To: Philipp Stephani , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 20 22:46:32 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCBGe-0003oc-Sb for ged-emacs-devel@m.gmane.org; Sat, 20 May 2017 22:46:29 +0200 Original-Received: from localhost ([::1]:35391 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCBGk-0000aW-D8 for ged-emacs-devel@m.gmane.org; Sat, 20 May 2017 16:46:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCBGd-0000aD-Ag for emacs-devel@gnu.org; Sat, 20 May 2017 16:46:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCBGa-0005kz-7N for emacs-devel@gnu.org; Sat, 20 May 2017 16:46:27 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41332) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dCBGZ-0005kp-UA for emacs-devel@gnu.org; Sat, 20 May 2017 16:46:24 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EBD84160051; Sat, 20 May 2017 13:46:21 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Kw0FyJDlO-us; Sat, 20 May 2017 13:46:21 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0929E16007F; Sat, 20 May 2017 13:46:21 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id r4vWa9E9ifuO; Sat, 20 May 2017 13:46:20 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C2C77160051; Sat, 20 May 2017 13:46:20 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215031 Archived-At: This is a multi-part message in MIME format. --------------987940A5A0E1E0ED63A76755 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable A couple of minor things I noticed in the recently-installed patch: > const short minargs =3D function->min_arity; In theory at least the arity might be greater than 32767, so this should = be=20 ptrdiff_t. Also, we typically don't use 'const' on locals, as it's not wo= rth the=20 screen real estate -- it should be easy even for a human reader to tell w= hether=20 a local is assigned to later. (Likewise for 'register'.) While looking into arity range I noticed a couple of other glitches in th= e=20 neighborhood, and so installed the attached. --------------987940A5A0E1E0ED63A76755 Content-Type: text/plain; charset=UTF-8; name="0001-Minor-fixes-for-arity-ranges-in-emacs-modules.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Minor-fixes-for-arity-ranges-in-emacs-modules.txt" RnJvbSA4NDhjOTBlM2Q0M2VkN2JhZWJhYjVmMmQwMmQwYTk2MDFjNmExNDJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDIwIE1heSAyMDE3IDEzOjQzOjE5IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gTWlub3IgZml4ZXMgZm9yIGFyaXR5IHJhbmdlcyBpbiBlbWFjcyBtb2R1bGVzCk1JTUUt VmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApD b250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgoqIHNyYy9lbWFjcy1tb2R1bGUuYyAo bW9kdWxlX21ha2VfZnVuY3Rpb24pOgpDaGVjayB0aGF0IGFyaXRpZXMgZml0IGludG8gZml4 bnVtcywgZm9yIGZ1bmMtYXJpdHnigJlzIGJlbmVmaXQuCihmdW5jYWxsX21vZHVsZSk6IEF2 b2lkIHVubmVjZXNzYXJ5IGNvbnZlcnNpb24gdG8gRU1BQ1NfSU5ULgoobW9kdWxlX2Z1bmN0 aW9uX2FyaXR5KTogQWxsb3cgYXJpdGllcyBncmVhdGVyIHRoYW4gU0hSVF9NQVguCi0tLQog c3JjL2VtYWNzLW1vZHVsZS5jIHwgMjIgKysrKysrKysrKystLS0tLS0tLS0tLQogMSBmaWxl IGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL3NyYy9lbWFjcy1tb2R1bGUuYyBiL3NyYy9lbWFjcy1tb2R1bGUuYwppbmRleCA5OWJl NGE3Li41YWI2OTEzIDEwMDY0NAotLS0gYS9zcmMvZW1hY3MtbW9kdWxlLmMKKysrIGIvc3Jj L2VtYWNzLW1vZHVsZS5jCkBAIC0zNTgsOCArMzU4LDkgQEAgbW9kdWxlX21ha2VfZnVuY3Rp b24gKGVtYWNzX2VudiAqZW52LCBwdHJkaWZmX3QgbWluX2FyaXR5LCBwdHJkaWZmX3QgbWF4 X2FyaXR5LAogCiAgIGlmICghICgwIDw9IG1pbl9hcml0eQogCSAmJiAobWF4X2FyaXR5IDwg MAotCSAgICAgPyBtYXhfYXJpdHkgPT0gZW1hY3NfdmFyaWFkaWNfZnVuY3Rpb24KLQkgICAg IDogbWluX2FyaXR5IDw9IG1heF9hcml0eSkpKQorCSAgICAgPyAobWluX2FyaXR5IDw9IE1P U1RfUE9TSVRJVkVfRklYTlVNCisJCSYmIG1heF9hcml0eSA9PSBlbWFjc192YXJpYWRpY19m dW5jdGlvbikKKwkgICAgIDogbWluX2FyaXR5IDw9IG1heF9hcml0eSAmJiBtYXhfYXJpdHkg PD0gTU9TVF9QT1NJVElWRV9GSVhOVU0pKSkKICAgICB4c2lnbmFsMiAoUWludmFsaWRfYXJp dHksIG1ha2VfbnVtYmVyIChtaW5fYXJpdHkpLCBtYWtlX251bWJlciAobWF4X2FyaXR5KSk7 CiAKICAgc3RydWN0IExpc3BfTW9kdWxlX0Z1bmN0aW9uICplbnZwdHIgPSBhbGxvY2F0ZV9t b2R1bGVfZnVuY3Rpb24gKCk7CkBAIC02NDYsMTIgKzY0NywxMSBAQCBMaXNwX09iamVjdAog ZnVuY2FsbF9tb2R1bGUgKGNvbnN0IHN0cnVjdCBMaXNwX01vZHVsZV9GdW5jdGlvbiAqY29u c3QgZW52cHRyLAogICAgICAgICAgICAgICAgIHB0cmRpZmZfdCBuYXJncywgTGlzcF9PYmpl Y3QgKmFyZ2xpc3QpCiB7Ci0gIEVNQUNTX0lOVCBsZW4gPSBuYXJnczsKICAgZWFzc3VtZSAo MCA8PSBlbnZwdHItPm1pbl9hcml0eSk7Ci0gIGlmICghIChlbnZwdHItPm1pbl9hcml0eSA8 PSBsZW4KLQkgJiYgbGVuIDw9IChlbnZwdHItPm1heF9hcml0eSA8IDAgPyBQVFJESUZGX01B WCA6IGVudnB0ci0+bWF4X2FyaXR5KSkpCisgIGlmICghIChlbnZwdHItPm1pbl9hcml0eSA8 PSBuYXJncworCSAmJiAoZW52cHRyLT5tYXhfYXJpdHkgPCAwIHx8IG5hcmdzIDw9IGVudnB0 ci0+bWF4X2FyaXR5KSkpCiAgICAgeHNpZ25hbDIgKFF3cm9uZ19udW1iZXJfb2ZfYXJndW1l bnRzLCBtb2R1bGVfZm9ybWF0X2Z1bl9lbnYgKGVudnB0ciksCi0JICAgICAgbWFrZV9udW1i ZXIgKGxlbikpOworCSAgICAgIG1ha2VfbnVtYmVyIChuYXJncykpOwogCiAgIGVtYWNzX2Vu diBwdWI7CiAgIHN0cnVjdCBlbWFjc19lbnZfcHJpdmF0ZSBwcml2OwpAQCAtNjYzLDEyICs2 NjMsMTIgQEAgZnVuY2FsbF9tb2R1bGUgKGNvbnN0IHN0cnVjdCBMaXNwX01vZHVsZV9GdW5j dGlvbiAqY29uc3QgZW52cHRyLAogICAgIGFyZ3MgPSAoZW1hY3NfdmFsdWUgKikgYXJnbGlz dDsKICAgZWxzZQogICAgIHsKLSAgICAgIGFyZ3MgPSBTQUZFX0FMTE9DQSAobGVuICogc2l6 ZW9mICphcmdzKTsKLSAgICAgIGZvciAocHRyZGlmZl90IGkgPSAwOyBpIDwgbGVuOyBpKysp CisgICAgICBhcmdzID0gU0FGRV9BTExPQ0EgKG5hcmdzICogc2l6ZW9mICphcmdzKTsKKyAg ICAgIGZvciAocHRyZGlmZl90IGkgPSAwOyBpIDwgbmFyZ3M7IGkrKykKIAlhcmdzW2ldID0g bGlzcF90b192YWx1ZSAoYXJnbGlzdFtpXSk7CiAgICAgfQogCi0gIGVtYWNzX3ZhbHVlIHJl dCA9IGVudnB0ci0+c3ViciAoJnB1YiwgbGVuLCBhcmdzLCBlbnZwdHItPmRhdGEpOworICBl bWFjc192YWx1ZSByZXQgPSBlbnZwdHItPnN1YnIgKCZwdWIsIG5hcmdzLCBhcmdzLCBlbnZw dHItPmRhdGEpOwogICBTQUZFX0ZSRUUgKCk7CiAKICAgZWFzc2VydCAoJnByaXYgPT0gcHVi LnByaXZhdGVfbWVtYmVycyk7CkBAIC03MDAsOCArNzAwLDggQEAgZnVuY2FsbF9tb2R1bGUg KGNvbnN0IHN0cnVjdCBMaXNwX01vZHVsZV9GdW5jdGlvbiAqY29uc3QgZW52cHRyLAogTGlz cF9PYmplY3QKIG1vZHVsZV9mdW5jdGlvbl9hcml0eSAoY29uc3Qgc3RydWN0IExpc3BfTW9k dWxlX0Z1bmN0aW9uICpjb25zdCBmdW5jdGlvbikKIHsKLSAgY29uc3Qgc2hvcnQgbWluYXJn cyA9IGZ1bmN0aW9uLT5taW5fYXJpdHk7Ci0gIGNvbnN0IHNob3J0IG1heGFyZ3MgPSBmdW5j dGlvbi0+bWF4X2FyaXR5OworICBwdHJkaWZmX3QgbWluYXJncyA9IGZ1bmN0aW9uLT5taW5f YXJpdHk7CisgIHB0cmRpZmZfdCBtYXhhcmdzID0gZnVuY3Rpb24tPm1heF9hcml0eTsKICAg cmV0dXJuIEZjb25zIChtYWtlX251bWJlciAobWluYXJncyksCiAJCW1heGFyZ3MgPT0gTUFO WSA/IFFtYW55IDogbWFrZV9udW1iZXIgKG1heGFyZ3MpKTsKIH0KLS0gCjIuNy40Cgo= --------------987940A5A0E1E0ED63A76755--