From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from deleted buffers, windows and frames. Date: Thu, 06 Sep 2012 09:28:52 +0200 Message-ID: <504850B4.7020002@gmx.at> References: <504848D0.4020908@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1346916540 16166 80.91.229.3 (6 Sep 2012 07:29:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Sep 2012 07:29:00 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 06 09:29:02 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T9WWM-0008GF-0C for ged-emacs-devel@m.gmane.org; Thu, 06 Sep 2012 09:29:02 +0200 Original-Received: from localhost ([::1]:38122 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9WWI-0008GR-Mv for ged-emacs-devel@m.gmane.org; Thu, 06 Sep 2012 03:28:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9WWA-0008G0-Q5 for emacs-devel@gnu.org; Thu, 06 Sep 2012 03:28:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9WW5-00034Q-1v for emacs-devel@gnu.org; Thu, 06 Sep 2012 03:28:50 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:34714) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1T9WW4-00034L-NV for emacs-devel@gnu.org; Thu, 06 Sep 2012 03:28:44 -0400 Original-Received: (qmail invoked by alias); 06 Sep 2012 07:28:43 -0000 Original-Received: from 62-47-46-79.adsl.highway.telekom.at (EHLO [62.47.46.79]) [62.47.46.79] by mail.gmx.net (mp033) with SMTP; 06 Sep 2012 09:28:43 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/hCAFqxsThaAifhtHdcG4eCtLIIbXpHPkRYsY9ls SwOa6123qufAG9 In-Reply-To: <504848D0.4020908@yandex.ru> X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153093 Archived-At: >> E.g. you might still be able to get (window|frame)-parameters of >> a deleted (window|frame). > > I'm pretty sure that this is invalid and should be fixed. Yes. It won't be allowed any more for windows. > Since we can't implement this just now, I'm reverting window marking; > but I think that I'll spent more time on this :-). ... and please tell the people from bug 12251 about it ;-) > Hm. For example, killed buffers may sit in all_buffers for a while, and > still > have from tens to thousands reachable objects per buffer (although I didn't > check whether these objects are reachable only from this dead buffer). Could you elaborate? > I agree about the safety, but: 1) this is slower; 2) IMHO this is > conceptually > wrong and 3) it still has it's own traps (for example, if we set all > Lisp_Objects > slot of the deleted window to Qnil, set-window-configuration will not > work since > it assumes that the restored window has valid marker objects at W->start > and W->pointm). Marker objects belong to the buffer. The start and pointm fields are regenerated from the saved window structure. Please elaborate. martin