From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Minor nsfont.m fix Date: Thu, 16 Aug 2012 21:37:18 -0700 Organization: UCLA Computer Science Department Message-ID: <502DCA7E.7000001@cs.ucla.edu> References: <502BAC06.9000909@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1345178242 22598 80.91.229.3 (17 Aug 2012 04:37:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2012 04:37:22 +0000 (UTC) Cc: =?UTF-8?B?SmFuIERqw6Rydg==?= , Emacs development discussions To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 17 06:37:22 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T2EJF-0001oS-8K for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2012 06:37:21 +0200 Original-Received: from localhost ([::1]:42499 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2EJE-0008Jp-4u for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2012 00:37:20 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2EJC-0008Jb-94 for emacs-devel@gnu.org; Fri, 17 Aug 2012 00:37:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2EJB-0003EN-9O for emacs-devel@gnu.org; Fri, 17 Aug 2012 00:37:18 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:36884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2EJB-0003EG-3U for emacs-devel@gnu.org; Fri, 17 Aug 2012 00:37:17 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id EBED4A60006; Thu, 16 Aug 2012 21:37:15 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BaU9cKTegcP1; Thu, 16 Aug 2012 21:37:15 -0700 (PDT) Original-Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 8FC9E39E8007; Thu, 16 Aug 2012 21:37:15 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 In-Reply-To: <502BAC06.9000909@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152599 On 08/15/2012 07:02 AM, Dmitry Antipov wrote: > Since we do not expect NULL from xmalloc and xzalloc, some redundant checks > may be omitted, OK? Yes, thanks, that makes sense. In this particular case, can't we go one better by replacing this: unichar *unichars = xmalloc (0x101 * sizeof (unichar)); ... xfree (unichars); with this? unichar unichars[0x101]; ...