From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Check in src/intervals.c, offset_intervals Date: Tue, 14 Aug 2012 01:33:14 -0700 Message-ID: <502A0D4A.5040205@cs.ucla.edu> References: <502251B0.3020000@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344933208 16757 80.91.229.3 (14 Aug 2012 08:33:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 14 Aug 2012 08:33:28 +0000 (UTC) Cc: Dmitry Antipov , Emacs development discussions To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 14 10:33:28 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T1CZ3-000197-8b for ged-emacs-devel@m.gmane.org; Tue, 14 Aug 2012 10:33:25 +0200 Original-Received: from localhost ([::1]:54573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1CZ2-00043P-BO for ged-emacs-devel@m.gmane.org; Tue, 14 Aug 2012 04:33:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1CYz-00042s-Qd for emacs-devel@gnu.org; Tue, 14 Aug 2012 04:33:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1CYv-0003Hr-AK for emacs-devel@gnu.org; Tue, 14 Aug 2012 04:33:21 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:59639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1CYv-0003Hk-4O for emacs-devel@gnu.org; Tue, 14 Aug 2012 04:33:17 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 5C0BAA60005; Tue, 14 Aug 2012 01:33:16 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QDmBjPeFcccC; Tue, 14 Aug 2012 01:33:16 -0700 (PDT) Original-Received: from [10.10.73.118] (unknown [208.181.80.18]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id C213CA60004; Tue, 14 Aug 2012 01:33:15 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152508 Archived-At: On 08/08/2012 04:56 AM, Andreas Schwab wrote: > Unless length is TYPE_MINIMUM (ptrdiff_t) (but the length is never > supposed to be negative). In that particular context, 'length' can be negative. I don't think 'length' can be PTRDIFF_MIN there. The IF_LINT test pacifies "gcc -O2 -Werror=strict-overflow". This warning flag is problematic because it sometimes has false alarms (as here) but it has found many bugs for me. Perhaps I should give up on that warning flag, in which case the IF_LINT test can be removed.