From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109327: Generalize INTERNAL_FIELD between buffers, keyboards and frames. Date: Wed, 08 Aug 2012 14:18:56 +0400 Message-ID: <50223D10.1080407@yandex.ru> References: <50191B54.2070705@yandex.ru> <5019FE2D.2060005@yandex.ru> <87r4rigihu.fsf@gnu.org> <502211C4.1010404@yandex.ru> <87628tj076.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344421014 6183 80.91.229.3 (8 Aug 2012 10:16:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2012 10:16:54 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 08 12:16:52 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sz3Jr-0003jh-Nq for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2012 12:16:51 +0200 Original-Received: from localhost ([::1]:47661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz3Jq-0004wb-Pi for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2012 06:16:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz3Jl-0004wW-Qf for emacs-devel@gnu.org; Wed, 08 Aug 2012 06:16:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sz3Jh-0004wo-Nz for emacs-devel@gnu.org; Wed, 08 Aug 2012 06:16:45 -0400 Original-Received: from forward10.mail.yandex.net ([77.88.61.49]:54847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz3Jd-0004vT-4r; Wed, 08 Aug 2012 06:16:37 -0400 Original-Received: from smtp6.mail.yandex.net (smtp6.mail.yandex.net [77.88.61.56]) by forward10.mail.yandex.net (Yandex) with ESMTP id 7C3AE1021C9C; Wed, 8 Aug 2012 14:16:35 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1344420995; bh=Cf9o5RsJIAGp0y27wXbKQ2OxeMcd18muX0EXFsPDhAU=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=wdu1DeoUPS5nWbtl+3xAhrtMNPD13fqGF7pt8IvP+mEwbcr7UCfPft2lnk8/aCepj lKn+MMxkmRNIeIBB5E2LM+BEI4L2FCVmqGNiXCzEq22ZxxfPFSIVy/2BbzLVtgrCST 2t8bdi1sB0UbKTS8yCXpAcGlEk/0DiNxdPtv3B18= Original-Received: from smtp6.mail.yandex.net (localhost [127.0.0.1]) by smtp6.mail.yandex.net (Yandex) with ESMTP id 4AE411640796; Wed, 8 Aug 2012 14:16:35 +0400 (MSK) Original-Received: from 233.gprs.mts.ru (233.gprs.mts.ru [213.87.132.233]) by smtp6.mail.yandex.net (nwsmtp/Yandex) with ESMTP id GXrmGMIA-GYrCU2MC; Wed, 8 Aug 2012 14:16:34 +0400 X-Yandex-Rcpt-Suid: cyd@gnu.org X-Yandex-Rcpt-Suid: monnier@IRO.UMontreal.CA X-Yandex-Rcpt-Suid: emacs-devel@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1344420995; bh=Cf9o5RsJIAGp0y27wXbKQ2OxeMcd18muX0EXFsPDhAU=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=R34nTnkLQhUX2dGMnFRGcRkoZcTSN3pLLKimNydsHZ0zNwNPqXarQ2HlwppOwb5ra Bn716vUN+h1cjj1QMR7SsMBgX209PZlXsPXJThYyc6q4bOC9ulWbJhnSZtaY7E7x61 h7VDNVJ/puiP5G8/8NRPQFYTxj4rYfaYnGgLKY2E= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 In-Reply-To: <87628tj076.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 77.88.61.49 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152329 Archived-At: On 08/08/2012 11:46 AM, Chong Yidong wrote: > Isn't the point of Coccinelle to make it possible to transform the code > with minimal manual intervention? YMMV - now it just refuses to parse the whole xdisp.c :-(. > With the Coccinelle scripts you've > written and committed, it shouldn't matter *when* we pull the trigger to > transform the direct accesses into *VAR macros. A lot of other pointers should be considered because not all pointers to collectable objects are represented by Lisp_Objects. > This will mitigate the > problem that "new GC tree will look so different so the final merge will > be a tremendous task". If the new GC tree starts out with the same code > transformations, the merge would involve running Coccinelle on the old > tree, then doing a diff between the result and the GC branch. Will look at further development of coccinelle; I don't believe that this is possible just now. > By the way, would you eventually need a macro for the common Vfoo = bar > case? Will see; I started from large objects with complex layout to hit all possible difficulties at the very beginning. Dmitry