From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109327: Generalize INTERNAL_FIELD between buffers, keyboards and frames. Date: Wed, 08 Aug 2012 11:14:12 +0400 Message-ID: <502211C4.1010404@yandex.ru> References: <50191B54.2070705@yandex.ru> <5019FE2D.2060005@yandex.ru> <87r4rigihu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344409935 17248 80.91.229.3 (8 Aug 2012 07:12:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2012 07:12:15 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 08 09:12:15 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sz0RC-0006fG-Jn for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2012 09:12:14 +0200 Original-Received: from localhost ([::1]:60606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz0RB-0007TX-RC for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2012 03:12:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz0R8-0007St-Pk for emacs-devel@gnu.org; Wed, 08 Aug 2012 03:12:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sz0R2-0007bR-NA for emacs-devel@gnu.org; Wed, 08 Aug 2012 03:12:10 -0400 Original-Received: from forward4.mail.yandex.net ([77.88.46.9]:33105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz0Qt-0007Xb-Ui; Wed, 08 Aug 2012 03:11:56 -0400 Original-Received: from smtp2.mail.yandex.net (smtp2.mail.yandex.net [77.88.46.102]) by forward4.mail.yandex.net (Yandex) with ESMTP id 8D3751BC25F5; Wed, 8 Aug 2012 11:11:54 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1344409914; bh=ql9gSiNItOyIUgTtoWzc+ptafi8DF2K4fZSKDKUcZHk=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=FMgLV4YZ7Yt92Yu0gdA9rtRAp/841Giq2ccu8RyC7UUbK+kxNRw59mDlumWj1XDw5 Xe0ihM40JPd1ks5/sW3mKpGBZ6eKsw8+TPiV8AzeUKptoICrYVxH8spZj6g+M1acM5 8EqzmDcEtCo54MUlQKcTsy+WNVkSH6rAyNh3WyVQ= Original-Received: from smtp2.mail.yandex.net (localhost [127.0.0.1]) by smtp2.mail.yandex.net (Yandex) with ESMTP id 585CEE205C4; Wed, 8 Aug 2012 11:11:54 +0400 (MSK) Original-Received: from 233.gprs.mts.ru (233.gprs.mts.ru [213.87.132.233]) by smtp2.mail.yandex.net (nwsmtp/Yandex) with ESMTP id BpJqGb0P-BrJ4Ybml; Wed, 8 Aug 2012 11:11:53 +0400 X-Yandex-Rcpt-Suid: cyd@gnu.org X-Yandex-Rcpt-Suid: monnier@IRO.UMontreal.CA X-Yandex-Rcpt-Suid: emacs-devel@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1344409914; bh=ql9gSiNItOyIUgTtoWzc+ptafi8DF2K4fZSKDKUcZHk=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=hZ/NonZhEs2hcQcWdJgwF9RwHg1Am4kSHnMFZIw//zQ+YsfAIIYs4KJuRqeT0vjxN XZgBji7cAKL+ALlVHmW5sX3+Nu182n1hmQsszUwotaGUEdK65yiFcqd0Y4bKJ7QiId GwTjdoCjdSQtANpG3CqRm6fIHmluXP84deo5MnsY= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 In-Reply-To: <87r4rigihu.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 77.88.46.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152322 Archived-At: On 08/08/2012 07:39 AM, Chong Yidong wrote: > Another problem, which I haven't seen mentioned in this thread, is that > when you see C code which does FVAR (x, y) the natural assumption is > that x and y are C variables. So these macros hurt code readability. > > The introduction of BVAR also violated this principle, and I'm not eager > to see the problem compounded. It looks like we should think about how to redesign BVARs and KVARs so that it should be suitable both for GC and concurrency development. > I think FSET/WSET/PSET/PGET/etc should be removed from the trunk, at > least for now. I recommend moving the generational GC work to a branch. Look at the size of changes I did just for a few days. This is just a preliminary changes needed to implement write barriers on top of them. Each pointer store is a subject to handle; most probably each source file will be affected. I suppose that new GC tree will look so different so the final merge will be a tremendous task on a few weeks. So I'm thinking about 2-stage approach: preliminary work is in trunk (where it might be used for concurrency branch and other development), and new GC (barriers and core GC bits) is in branch. Dmitry