From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 5/9] Prevent crash if w32 used before it's initialized Date: Tue, 07 Aug 2012 10:28:08 -0700 Message-ID: <50215028.4070708@dancol.org> References: <3cb1f39b5711d712c2ec79d6a578044b1b432149.1344326992.git.dancol@dancol.org> <83pq72fwga.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFE87845828DDD714052E6625" X-Trace: dough.gmane.org 1344360503 14267 80.91.229.3 (7 Aug 2012 17:28:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2012 17:28:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 07 19:28:24 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SynZt-0008BT-2y for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 19:28:21 +0200 Original-Received: from localhost ([::1]:55160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SynZs-0005i0-BI for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 13:28:20 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SynZq-0005hr-CF for emacs-devel@gnu.org; Tue, 07 Aug 2012 13:28:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SynZp-0008G3-El for emacs-devel@gnu.org; Tue, 07 Aug 2012 13:28:18 -0400 Original-Received: from dancol.org ([96.126.100.184]:38311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SynZn-0008Fi-MY; Tue, 07 Aug 2012 13:28:15 -0400 Original-Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[192.168.1.2]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SynZm-0007bX-FG; Tue, 07 Aug 2012 10:28:14 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:14.0) Gecko/20120713 Thunderbird/14.0 In-Reply-To: <83pq72fwga.fsf@gnu.org> X-Enigmail-Version: 1.4.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 96.126.100.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152271 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFE87845828DDD714052E6625 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 8/7/12 10:23 AM, Eli Zaretskii wrote: >> Date: Tue, 07 Aug 2012 01:19:27 -0700 >> From: Daniel Colascione >> >> --- >> src/w32fns.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/src/w32fns.c b/src/w32fns.c >> index 8ef4982..9743822 100644 >> --- a/src/w32fns.c >> +++ b/src/w32fns.c >> @@ -4833,7 +4833,7 @@ x_display_info_for_name (Lisp_Object name) >> CHECK_STRING (name); >> =20 >> for (dpyinfo =3D &one_w32_display_info, names =3D w32_display_name_= list; >> - dpyinfo; >> + dpyinfo && !NILP (w32_display_name_list); >> dpyinfo =3D dpyinfo->next, names =3D XCDR (names)) >> { >> Lisp_Object tem; >=20 > Is this a real problem with the native w32 build? If so, can you tell > how to reproduce it? No --- it's something that came up in my testing late last year, and I've forgotten the exact circumstances of the problem now. The change seems harmless enough though. --------------enigFE87845828DDD714052E6625 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlAhUCkACgkQ17c2LVA10VsCmACeK7GVGNmqgeLdwHz08FEX2k/a TNUAmgIdBJljxv8qJV8DrAwJqF9HqXgR =PuvR -----END PGP SIGNATURE----- --------------enigFE87845828DDD714052E6625--