Re: [PATCH 5/9] Prevent crash if w32 used before it's initialized

[Daniel Colascione <dancol@dancol.org>]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

On 8/7/12 10:23 AM, Eli Zaretskii wrote:
>> Date: Tue, 07 Aug 2012 01:19:27 -0700
>> From: Daniel Colascione <dancol@dancol.org>
>>
>> ---
>>  src/w32fns.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/w32fns.c b/src/w32fns.c
>> index 8ef4982..9743822 100644
>> --- a/src/w32fns.c
>> +++ b/src/w32fns.c
>> @@ -4833,7 +4833,7 @@ x_display_info_for_name (Lisp_Object name)
>>    CHECK_STRING (name);
>>  
>>    for (dpyinfo = &one_w32_display_info, names = w32_display_name_list;
>> -       dpyinfo;
>> +       dpyinfo && !NILP (w32_display_name_list);
>>         dpyinfo = dpyinfo->next, names = XCDR (names))
>>      {
>>        Lisp_Object tem;
> 
> Is this a real problem with the native w32 build?  If so, can you tell
> how to reproduce it?

No --- it's something that came up in my testing late last year, and
I've forgotten the exact circumstances of the problem now. The change
seems harmless enough though.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 235 bytes --]