From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109327: Generalize INTERNAL_FIELD between buffers, keyboards and frames. Date: Fri, 03 Aug 2012 12:31:04 +0400 Message-ID: <501B8C48.3000704@yandex.ru> References: <50191B54.2070705@yandex.ru> <5019FE2D.2060005@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1343982536 3972 80.91.229.3 (3 Aug 2012 08:28:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 3 Aug 2012 08:28:56 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 03 10:28:57 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SxDFf-00056e-AY for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2012 10:28:55 +0200 Original-Received: from localhost ([::1]:52341 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxDFe-0005Ce-I6 for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2012 04:28:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxDFZ-0005As-2f for emacs-devel@gnu.org; Fri, 03 Aug 2012 04:28:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxDFV-00064Z-6i for emacs-devel@gnu.org; Fri, 03 Aug 2012 04:28:49 -0400 Original-Received: from forward4h.mail.yandex.net ([84.201.186.22]:43306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxDFU-00064Q-RN for emacs-devel@gnu.org; Fri, 03 Aug 2012 04:28:45 -0400 Original-Received: from smtp4h.mail.yandex.net (smtp4h.mail.yandex.net [84.201.186.21]) by forward4h.mail.yandex.net (Yandex) with ESMTP id 21A3C1B21AEF; Fri, 3 Aug 2012 12:28:43 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1343982523; bh=7HijxV5U5M9AbTqsj9tyQoKzljYCn0b8Lrd6tC55gH4=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=HDUNHjyajYw7D1ghFIySLwhqBGrdSgxKjvWNKobm/VbcuN6ND6we1teuCRnhbWfM+ Yc9woCAuCwVO1kIgwjeRhAcsPrPQPyJki3Kp/UPG9QyzwuZjJEJnuceDl2LVQPYn3k AkYD7LPYghHONlKHB0r8KQZO+wHBm0RRAGpNJUag= Original-Received: from smtp4h.mail.yandex.net (localhost [127.0.0.1]) by smtp4h.mail.yandex.net (Yandex) with ESMTP id D89252C0028; Fri, 3 Aug 2012 12:28:42 +0400 (MSK) Original-Received: from 93.gprs.mts.ru (93.gprs.mts.ru [213.87.131.93]) by smtp4h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id SeACm0a7-SfA0dF8o; Fri, 3 Aug 2012 12:28:41 +0400 X-Yandex-Rcpt-Suid: monnier@IRO.UMontreal.CA X-Yandex-Rcpt-Suid: emacs-devel@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1343982522; bh=7HijxV5U5M9AbTqsj9tyQoKzljYCn0b8Lrd6tC55gH4=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Lre8/+45B1yzSHFqLc9jKx+NKt8jFwZExQyDNPUVPChzp7+5aOh+ZPMYUXN+JQ72s NnUOuD/JB4s8t3SgvNt44+3ETJx9+F77YuCnHLN1vyltEZgDIRZBexwInFmHRypqlw L5qRh6rDokXuyDBIa88PvSc7841UzYvREMRTTIRw= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 84.201.186.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152139 Archived-At: On 08/03/2012 11:42 AM, Stefan Monnier wrote: >> the barrier (just one such a store is fatal for the collector). Next, >> when we will know that the collector invariant is never broken, it's >> possible to replace these obfuscated FVAR (x, y) back to x->y. > > You can use coccinelle to automatically turn the x->y into an rvalue > FVAR (x,y) while debugging. And such a script should be kept around and > run every once in a while to check that new code follows the > SETFVAR convention. > > But I don't want the trunk's code obfuscated just for some temporary > debugging needs. Have you tried to use coccinelle? As I have said, it's not a silver bullet (yet), and it's just impossible to handle such a stuff in fully automated mode. There are special cases that should be handled manually, and doing them over and over again is much worse than even an endless merging. And I still don't see an answer to the simplest possible question: why (F|W)VARs are so bad but (B|K)VARs are OK? Dmitry