Re: Note on 109327

[Dmitry Antipov <dmantipov@yandex.ru>]

On 07/31/2012 09:04 PM, Eli Zaretskii wrote:

> This problem, however, is more serious, IMO:
>
>    gcc -I. -c -gdwarf-2 -g3  -DEMACSDEBUG -fno-crossjumping  -Id:/usr/include/libxml2 -DGLYPH_DEBUG=1 -Demacs=1 -I../lib -I../nt/inc -DHAVE_NTGUI=1 -DUSE_CRT_DLL=1 -o oo/i386/w32menu.o w32menu.c
>    w32menu.c: In function `w32_menu_show':
>    w32menu.c:857: error: structure has no member named `title_'
>    makefile:322: recipe for target `oo/i386/w32menu.o' failed
>    make[1]: *** [oo/i386/w32menu.o] Error 1
>
> AFAIU, it means that coccinelle made an incorrect replacement.

Yes, it's not a silver bullet (yet). And, of course, I'm not a heavily
experienced user.

> I fixed both of these in revision 109332.

Thanks.

> Btw, can't we have in Emacs a feature that would allow such
> refactoring?  The replacements don't seem too complex to me.  Adding
> this to Emacs will both allow getting rid of an external tool, and be
> a valuable addition to Emacs abilities.  WDYT?

IIUC real refactoring of C should imply preprocessing and full
syntactic analysis, so, I'm thinking about GCC plugin.

Nevertheless, I suppose that it should be possible to build
simple refactoring engine on top of cc-mode, and such an engine
may provide basic features like intelligent renaming of identifiers
or tweaking function arguments.

Dmitry