From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: Windows build broken on trunk Date: Wed, 18 Jul 2012 13:55:59 +0400 Message-ID: <5006882F.2060503@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1342605255 21980 80.91.229.3 (18 Jul 2012 09:54:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 18 Jul 2012 09:54:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 18 11:54:11 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SrQxP-0002Pc-0S for ged-emacs-devel@m.gmane.org; Wed, 18 Jul 2012 11:54:11 +0200 Original-Received: from localhost ([::1]:54465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrQxO-0001pz-CW for ged-emacs-devel@m.gmane.org; Wed, 18 Jul 2012 05:54:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrQxH-0001mh-Gb for emacs-devel@gnu.org; Wed, 18 Jul 2012 05:54:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrQxA-0007Br-Ml for emacs-devel@gnu.org; Wed, 18 Jul 2012 05:54:03 -0400 Original-Received: from forward13.mail.yandex.net ([95.108.130.120]:57716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrQxA-0007Bf-AC for emacs-devel@gnu.org; Wed, 18 Jul 2012 05:53:56 -0400 Original-Received: from smtp12.mail.yandex.net (smtp12.mail.yandex.net [95.108.131.191]) by forward13.mail.yandex.net (Yandex) with ESMTP id 10FAD1426E5; Wed, 18 Jul 2012 13:53:45 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1342605225; bh=iP6RxYAvO53wIFDnCu39yalLgGNSFj/55vGUFTCakEo=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=r8Ni+2IY7/f88DRGxeWGizkSeV/UyWdLjqLbSr0e4z2+hZ7GbVIkKoUjwczXUpMWq BlC/qOIcwaLn54kLU7Oz//Xo8sWqza/E47Xy4bdEE/djwyIgKPlAPLY6B/67qNVMki l6HZlvz+L1LQTUa4Jtk4H6MlflyfLjGi0JcPRkiU= Original-Received: from smtp12.mail.yandex.net (localhost [127.0.0.1]) by smtp12.mail.yandex.net (Yandex) with ESMTP id E1D5516A0140; Wed, 18 Jul 2012 13:53:44 +0400 (MSK) Original-Received: from 13.gprs.mts.ru (13.gprs.mts.ru [213.87.129.13]) by smtp12.mail.yandex.net (nwsmtp/Yandex) with ESMTP id rbOKYMDU-rgOuAoqO; Wed, 18 Jul 2012 13:53:44 +0400 X-Yandex-Rcpt-Suid: andrewjmoreton@gmail.com X-Yandex-Rcpt-Suid: emacs-devel@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1342605224; bh=iP6RxYAvO53wIFDnCu39yalLgGNSFj/55vGUFTCakEo=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=hpB+wCBiK2X7TgraND1/5DAMweJtFR9JwoVh+77gb/UJx+gOZdcMJGsDDC8atjqFv xAkPWhJLmy16+3DgVFlRbjBFx39sGH9r/SOX5yjHCKRItzaqnrq/WX6WYnu+b4XZ1I WQ5VDB1JKfrJJGD0Vxw4kKa066NbyFOfGPz7cCA4= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 95.108.130.120 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151724 Archived-At: On 07/18/2012 12:42 PM, Andy Moreton wrote: > Bootstrapping trunk on Windows (mingw32 GCC 4.6.1) failed this morning: > > w32font.c:78:40: error: static declaration of 'Qsymbol' follows non-static declaration > lisp.h:2335:41: note: previous declaration of 'Qsymbol' was here > mingw32-make[3]: *** [oo/i386/w32font.o] Error 1 > mingw32-make[3]: Leaving directory `C:/emacs/src/emacs/trunk/src' > > This appers to be from r109131 committed by Dmitry Antipov. > > I'm not familiar with the code: is the static Qsymbol used in w32font.c > referring to some aspect of font handling, or is it the same thing as the > global that was added to src/lisp.h ? IIUC it's font handling stuff, and (IMHO) it should be renamed from too generic name to something which is closely related to symbol's real use. Dmitry