From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jean-Christophe Helary Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Wed, 10 May 2017 12:49:35 +0900 Message-ID: <50036084-C652-4382-A1F5-500C81916703@gmail.com> References: <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> <838tmafigi.fsf@gnu.org> <7C79DA34-96F2-4D9F-9E9C-01574AE00F12@gmail.com> <8360hefepp.fsf@gnu.org> <0E129E02-FA64-4664-825B-8854A66CA9C6@gmail.com> <3D0BA0E6-02E2-4E90-8A59-121065547E1C@gmail.com> <87ziepho0q.fsf@gnu.org> <83vapderm3.fsf@gnu.org> <87vapdhi9j.fsf@gnu.org> <83tw4xeorf.fsf@gnu.org> <83vapbctij.fsf@gnu.org> <87vapb9dd8.fsf@gnu.org> <877f1qutfq.fsf@drachen> <83wp9qawav.fsf@gnu.org> <0843BD47-5297-4B55-B870-BBE3AEB59D23@gmail.com> <83shkeatlw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1494388233 25498 195.159.176.226 (10 May 2017 03:50:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 10 May 2017 03:50:33 +0000 (UTC) Cc: Tino Calancha , Michael Heerdegen , =?utf-8?Q?Johan_Bockg=C3=A5rd?= , emacs-devel , Mark Oteiza , Eli Zaretskii To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 10 05:50:27 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8Idu-0006SF-Uw for ged-emacs-devel@m.gmane.org; Wed, 10 May 2017 05:50:27 +0200 Original-Received: from localhost ([::1]:40271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Idy-0003yp-Uh for ged-emacs-devel@m.gmane.org; Tue, 09 May 2017 23:50:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8IdI-0003yh-QH for emacs-devel@gnu.org; Tue, 09 May 2017 23:49:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8IdI-0002F1-06 for emacs-devel@gnu.org; Tue, 09 May 2017 23:49:48 -0400 Original-Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:35322) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8IdC-0002BC-At; Tue, 09 May 2017 23:49:42 -0400 Original-Received: by mail-pf0-x242.google.com with SMTP id u26so2272935pfd.2; Tue, 09 May 2017 20:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=GqwpvUQIzuNkifRiV1LTOtABQK2zQaxclJTpCJIZAW0=; b=r/SkcNQV0C1PF/MbqyAYOvkCc91XatY2JFte8nAQRckoehNl/u9cYIp+MnviRS23De Shh0w+uhL3JUtWTBOlujrAmGeuxqdtUnseTqwfhpzN08VX/zdNhw2HwxrIsV8zeK4PrR ffoKWAcxIhVzHOhNsj75h51lo2cu2EwfO3s8dW5VabXNjz5N8UXRYG/sr1dMORSkPhjc u505gT/+Os1POgRQPQamEztSGJjNmTc9zNpUuWpwaJnV5Z0AHy5AIK+t9ZFOFRlvKIsO tt3k5P1KT0lTDtdCeo68LmpgVNIWxfh+eFNAcSdstYWAdctK5T3mLYu0qkJS2XvhSHoN WKaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=GqwpvUQIzuNkifRiV1LTOtABQK2zQaxclJTpCJIZAW0=; b=RRM0cm/jp7w0kUPBDtsvbz3aXrodOD42tDTbcXNYNbROe9VoIe5fu2hgaj0At408YJ Zr1+uEud/TDFr/mHsG1N7R32UG3vswbIwXlqd0pGs/sBp+wWMUD1rH415HaTIIsdeSD/ tBfdRVs2c5dKgmakzwpB77AEedhR6rbyr/6TBBoJQm99xsneul7KmdBG3KbZIuZQIOKE KFMLn8kgGNWgapUVKXWnuUa8hVSBKqQgzQQcdHfHAo+wDI7BjQhDTADLuMiFb/6LPGXe QPJaG43g/hURN9dXxoR1ZeX7fY5msnkokJqFupVP4My8srQkATpuzz+KHimYCMYAxbKi OzSQ== X-Gm-Message-State: AODbwcBu2zEWFtitn4kZ9XdxkmTXkCQtzfE939ecdb7bYI8lqo253bS+ pAZUFrMFx1jB2w== X-Received: by 10.84.139.3 with SMTP id 3mr3701729plq.79.1494388181192; Tue, 09 May 2017 20:49:41 -0700 (PDT) Original-Received: from [10.254.2.140] ([210.160.37.43]) by smtp.gmail.com with ESMTPSA id x21sm2341218pfa.71.2017.05.09.20.49.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2017 20:49:40 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214741 Archived-At: > On May 10, 2017, at 9:45, Stefan Monnier = wrote: >=20 >> Since what I propose is consistant with the existing code, not = agreeing with >> that means *first* finding the bug that Johan mentioned (which is not >> directly related to my modification), starting a review process of = the whole >> code base that uses subr.el/split-string (and maybe other places = where that >> regexp bug happens), fixing the code to ensure some kind of backward >> compatibility, etc. and *then* applying my change to subr-x... >=20 > I'm pretty sure surrounding the regexp in \(?:..\) will break no code = at > all. To me it's an absolute no-brainer that doesn't even merit any = discussion. That does not seem to be the case. Johan has identified a case where a = regexp that uses \| does not produce the same result as the "trim" = argument of split-string whether it uses \( \) or not. So there is the possibility that code that use the "trim" argument will = produce an unexpected result if split-string is modified. I am not talking about subr-x.el, it is an addition that is backward = compatible since the new argument is optional. Jean-Christophe=20=