* Re: [Emacs-diffs] master 55496af: * lisp/emacs-lisp/ert.el (ert--special-operator-p):
[not found] ` <E1YnzbZ-0000QU-8E@vcs.savannah.gnu.org>
@ 2015-05-01 2:36 ` Stefan Monnier
2015-05-01 15:30 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2015-05-01 2:36 UTC (permalink / raw)
To: emacs-devel; +Cc: Glenn Morris
> - (let ((definition (indirect-function thing t)))
> + (let ((definition (ignore-errors (indirect-function thing))))
Why `ignore-errors'? The Emacs-25 behavior of (indirect-function thing)
is the same as the old (indirect-function thing t), AFAIK (hence the
removal of the now redundant argument).
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Emacs-diffs] master 55496af: * lisp/emacs-lisp/ert.el (ert--special-operator-p):
2015-05-01 2:36 ` [Emacs-diffs] master 55496af: * lisp/emacs-lisp/ert.el (ert--special-operator-p): Stefan Monnier
@ 2015-05-01 15:30 ` Glenn Morris
2015-05-01 18:21 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2015-05-01 15:30 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier wrote:
>> - (let ((definition (indirect-function thing t)))
>> + (let ((definition (ignore-errors (indirect-function thing))))
>
> Why `ignore-errors'?
My mistake.
> The Emacs-25 behavior of (indirect-function thing) is the same as the
> old (indirect-function thing t), AFAIK (hence the removal of the now
> redundant argument).
Something like that should be in NEWS.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 55496af: * lisp/emacs-lisp/ert.el (ert--special-operator-p):
2015-05-01 15:30 ` Glenn Morris
@ 2015-05-01 18:21 ` Stefan Monnier
2015-05-02 1:40 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2015-05-01 18:21 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
>> The Emacs-25 behavior of (indirect-function thing) is the same as the
>> old (indirect-function thing t), AFAIK (hence the removal of the now
>> redundant argument).
> Something like that should be in NEWS.
I hesitated: the change is actually a missing change in 24.4 (where
`symbol-function' was changed to not signal void-function any more, but
where I did not make the corresponding change in `indirect-function').
So to me it's just a bug fix.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Emacs-diffs] master 55496af: * lisp/emacs-lisp/ert.el (ert--special-operator-p):
2015-05-01 18:21 ` Stefan Monnier
@ 2015-05-02 1:40 ` Glenn Morris
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2015-05-02 1:40 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier wrote:
> I hesitated: the change is actually a missing change in 24.4 (where
> `symbol-function' was changed to not signal void-function any more, but
> where I did not make the corresponding change in `indirect-function').
> So to me it's just a bug fix.
The rest of us need these clues, to help us figure out what you did. :)
It has practical consequences, so it should be in NEWS. Eg this will
prompt Someone to update the elisp manual, which still describes the old
behaviour.
IMO: if in doubt, make a NEWS entry. It can always be deleted before the
release, when Someone reviews the NEWS file.
(TIA, Someone!)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-02 1:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150501011901.1604.3645@vcs.savannah.gnu.org>
[not found] ` <E1YnzbZ-0000QU-8E@vcs.savannah.gnu.org>
2015-05-01 2:36 ` [Emacs-diffs] master 55496af: * lisp/emacs-lisp/ert.el (ert--special-operator-p): Stefan Monnier
2015-05-01 15:30 ` Glenn Morris
2015-05-01 18:21 ` Stefan Monnier
2015-05-02 1:40 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).