From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: Add M-x occur to the menu-bar Date: Thu, 12 Feb 2004 15:34:54 -0500 Organization: =?koi8-r?q?=F4=C5=CF=C4=CF=D2=20=FA=CC=C1=D4=C1=CE=CF=D7?= @ Cienfuegos Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <4nr7x0ox3l.fsf@collins.bwh.harvard.edu> References: <3F69E6FF.9050702@yahoo.com> <4n8yjto16h.fsf@collins.bwh.harvard.edu> <4nisixjibl.fsf@collins.bwh.harvard.edu> <20040127230323.GB5407@fencepost> <4n7jzc919v.fsf@collins.bwh.harvard.edu> <4nn085i7nl.fsf@collins.bwh.harvard.edu> <4noese37h0.fsf@collins.bwh.harvard.edu> <4nbrodxwqm.fsf@collins.bwh.harvard.edu> <4n8yjcccvj.fsf@collins.bwh.harvard.edu> <4nwu6sp7ni.fsf@collins.bwh.harvard.edu> Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ArNcZ-0006IL-00 for ; Thu, 12 Feb 2004 21:39:39 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1ArNcZ-0000ku-00 for ; Thu, 12 Feb 2004 21:39:39 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ArNcE-0004qE-Jo for emacs-devel@quimby.gnus.org; Thu, 12 Feb 2004 15:39:18 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1ArNbl-0004lW-KP for emacs-devel@gnu.org; Thu, 12 Feb 2004 15:38:49 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1ArNbF-0004Ts-P2 for emacs-devel@gnu.org; Thu, 12 Feb 2004 15:38:48 -0500 Original-Received: from [134.174.9.41] (helo=clifford.bwh.harvard.edu) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ArNbF-0004Tm-Gu for emacs-devel@gnu.org; Thu, 12 Feb 2004 15:38:17 -0500 Original-Received: from collins.bwh.harvard.edu (collins [134.174.9.80]) by clifford.bwh.harvard.edu (8.10.2+Sun/8.11.0) with ESMTP id i1CKZ7U27620; Thu, 12 Feb 2004 15:35:08 -0500 (EST) Original-Received: from collins.bwh.harvard.edu (localhost [127.0.0.1]) by collins.bwh.harvard.edu (8.12.9+Sun/8.11.0) with ESMTP id i1CKYuvl014864; Thu, 12 Feb 2004 15:34:56 -0500 (EST) Original-Received: (from tzz@localhost) by collins.bwh.harvard.edu (8.12.9+Sun/8.12.9/Submit) id i1CKYtf4014861; Thu, 12 Feb 2004 15:34:55 -0500 (EST) Original-To: Stefan Monnier X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" In-Reply-To: (Stefan Monnier's message of "12 Feb 2004 14:48:24 -0500") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (usg-unix-v) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19899 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19899 On 12 Feb 2004, monnier@iro.umontreal.ca wrote: >> I saw some discussion of a compile.el update, I hope the new >> version preserves this patch's behavior. > > Right now it doesn't. > But it should not be difficult to change. OK, I'll be glad to up-rev the patch as needed. > By the way: why (make-variable-buffer-local > 'compilation-next-error-function)? It seems completely unnecessary. > People can make-local-variable when needed. It's generally clearer > if they do it anyway. I think Kim suggested that. It's so that multiple modes can set compilation-next-error-function without using make-local-variable. If you change it, you're just pushing that work to the modes that use this interface. I think it's 6 one way, half-dozen the other, so whatever the Emacs developers prefer is fine with me. > Also why not rename next-error to compilation-next-error, then > default compilation-next-error-function to compilation-next-error > and just write: > > (defun next-error (argp) > (interactive ...) > (with-current-buffer compilation-last-buffer > (funcall compilation-next-error-function argp)) compilation-last-buffer is not necessarily what we want. We need to find a suitable buffer, so you can run next-error anywhere and at any time. That preserves the existing semantics of next-error; I don't think your version does. I may be wrong, though. Ted