From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: next-error-last-buffer Date: Fri, 28 May 2004 23:35:46 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <4nhdtzdhwt.fsf@lifelogs.com> References: <871xluig40.fsf@mail.jurta.org> <87u0y6jjq9.fsf@mail.jurta.org> <87n03wgt76.fsf@mail.jurta.org> <4nd64rl2ah.fsf@lifelogs.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1085806653 29466 80.91.224.253 (29 May 2004 04:57:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 29 May 2004 04:57:33 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat May 29 06:57:28 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BTvuS-0007kt-00 for ; Sat, 29 May 2004 06:57:28 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BTvuO-0003CN-00 for ; Sat, 29 May 2004 06:57:24 +0200 Original-Received: from [127.0.0.1] (helo=mailman.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BTvuS-0007jK-41 for emacs-devel@quimby.gnus.org; Sat, 29 May 2004 00:57:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BTvu6-0007Xf-PK for emacs-devel@gnu.org; Sat, 29 May 2004 00:57:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BTvu4-0007WZ-4o for emacs-devel@gnu.org; Sat, 29 May 2004 00:57:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BTvu4-0007WQ-0n for emacs-devel@gnu.org; Sat, 29 May 2004 00:57:04 -0400 Original-Received: from [199.232.41.8] (helo=mx20.gnu.org) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1BTvr5-0001DL-Fe for emacs-devel@gnu.org; Sat, 29 May 2004 00:53:59 -0400 Original-Received: from [80.91.224.249] (helo=main.gmane.org) by mx20.gnu.org with esmtp (Exim 4.34) id 1BTuy3-00005x-Pq for emacs-devel@gnu.org; Fri, 28 May 2004 23:57:08 -0400 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1BTuu1-0004JY-00 for ; Sat, 29 May 2004 05:52:57 +0200 Original-Received: from asimov.bwh.harvard.edu ([134.174.9.63]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 29 May 2004 05:52:57 +0200 Original-Received: from tzz by asimov.bwh.harvard.edu with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 29 May 2004 05:52:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 23 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: asimov.bwh.harvard.edu X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) Cancel-Lock: sha1:qy+guZG+de/Nch/RBIZQWwkFlSo= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24129 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24129 On 28 May 2004, monnier@iro.umontreal.ca wrote: > A less intrusive (and hence less complete) solution: > > - Create a new compilation-last-source-buffer variable. > - At the end of next-error, set this new variable to the buffer just being > displayed. > - at the beginning of next-error check compilation-last-source-buffer: > if it is equal to current-buffer, then don't consider this buffer as > a "compilation" buffer (i.e. ignore its next-error-function). > > This way if a C-x ` lands us in a diff-mode buffer (because of a *grep* that > points to a patch file), a subsequent C-x ` in the same buffer will not > mistakenly step through the diffs of this buffer but will go to the next > grep match. I think my proposal to reorder the rules of next-error-find-buffer to use next-error-last-buffer BEFORE (current-buffer) is essentially what you are proposing. If not, let me know. Ted