* Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version'
[not found] ` <20180216093117.66FB5206A2@vcs0.savannah.gnu.org>
@ 2018-02-16 16:56 ` Glenn Morris
2018-02-16 17:22 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2018-02-16 16:56 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
Eli Zaretskii wrote:
> commit 6ddb4bd39ac0629e4e06221a41120aee7c18f548
> * lisp/vc/vc-git.el (vc-git--program-version): Fix the function to
> work with Git for Windows.
> - (string-match "git version \\([0-9.]+\\)$"
> - version-string))
> + ;; Git for Windows appends ".windows.N" to the
> + ;; numerical version reported by Git.
> + (string-match
> + "git version \\([0-9.]+\\)\\(\.windows.[0-9]+\\)$"
> + version-string))
Surely this breaks on all non-MS Windows platforms?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version'
2018-02-16 16:56 ` emacs-26 6ddb4bd: Fix 'vc-git--program-version' Glenn Morris
@ 2018-02-16 17:22 ` Eli Zaretskii
2018-02-18 0:17 ` Richard Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2018-02-16 17:22 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> From: Glenn Morris <rgm@gnu.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 16 Feb 2018 11:56:05 -0500
>
> > * lisp/vc/vc-git.el (vc-git--program-version): Fix the function to
> > work with Git for Windows.
> > - (string-match "git version \\([0-9.]+\\)$"
> > - version-string))
> > + ;; Git for Windows appends ".windows.N" to the
> > + ;; numerical version reported by Git.
> > + (string-match
> > + "git version \\([0-9.]+\\)\\(\.windows.[0-9]+\\)$"
> > + version-string))
>
> Surely this breaks on all non-MS Windows platforms?
Given how much time it was "broken" on Windows without anyone
noticing, isn't it just fair that we leave it "broken" on non-Windows
platforms for approximately the same time?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-18 0:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180216093116.572.67356@vcs0.savannah.gnu.org>
[not found] ` <20180216093117.66FB5206A2@vcs0.savannah.gnu.org>
2018-02-16 16:56 ` emacs-26 6ddb4bd: Fix 'vc-git--program-version' Glenn Morris
2018-02-16 17:22 ` Eli Zaretskii
2018-02-18 0:17 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).